Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android bug to show Snackbar over multiple modals rendered #179

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

ManuelMGM
Copy link
Contributor

Hi @cooperka, i was facing the not common scenario trying to render Snackbar over multiple modals.

On iOS devices issue in not reproducible.

On Android instead, when multiple modals were rendered, snackbar is showing behind modala (only over the first modal dispatched).
Seems like chages made on this fix were not completely correct. The order of modals view added on the ArrayList should be reverse.

I've tested and now is working fine on both iOS and Android devices.

Hope it helps!
Manuel.

@cooperka
Copy link
Owner

cooperka commented Mar 8, 2021

Thanks for testing this @ManuelMGM! In the absence of a robust way for me to verify this myself, I'll trust that this improves things for most users (though it may have the opposite effect on some apps who expect it to behave the old way). I'll note this in the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants