Clear remove idle timer after destroyAllNow #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps track of the remove idle timer and will clear the timer when destroyAllNow is called, as after all clients are destroyed there is no need to check for idle clients any longer. Without clearing the timer, a program may have called destroyAllNow because it was about to exit, but if the remove idle timer still exists, the event loop will continue running until at most realIntervalMillis.
coopernurse
added a commit
that referenced
this pull request
Jun 27, 2012
Clear remove idle timer after destroyAllNow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps track of the remove idle timer and will clear the timer when
destroyAllNowis called, as after all clients are destroyed there is no need to check for idle clients any longer. Without clearing the timer, a program may have calleddestroyAllNowbecause it was about to exit, but if the remove idle timer still exists,the event loop will continue running until at most
realIntervalMillis.Plus, clearing this timer is just awesome in general, as it prevents unnecessary work.