Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme code samples #9

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Readme code samples #9

merged 2 commits into from
Feb 17, 2022

Conversation

hawi74
Copy link
Contributor

@hawi74 hawi74 commented Feb 17, 2022

Add code samples:

  • how to use global logger
  • how to set logger level

Also:

  • re-worded the comment about why global logger output has to be overwritten in testable examples, as it was confusing, I'd appreciate any feedback if it still is :)
  • name of the file with testable examples is now a link instead of plain text

Closes #5

@hawi74 hawi74 requested a review from a team as a code owner February 17, 2022 10:05
@hawi74 hawi74 merged commit ec482da into main Feb 17, 2022
@hawi74 hawi74 deleted the readme-code-samples branch February 17, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aucampia aucampia aucampia approved these changes

@martinostvik martinostvik martinostvik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include example of setting log level
3 participants
@hawi74 @aucampia @martinostvik