Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overriding Location Entity #11

Closed
davidroberto opened this issue Apr 10, 2020 · 1 comment · Fixed by #12
Closed

Overriding Location Entity #11

davidroberto opened this issue Apr 10, 2020 · 1 comment · Fixed by #12

Comments

@davidroberto
Copy link

Hi,

I believe the Traits ClickNCollectShippingMethod and ClickNCollectShipment should type-hint LocationInterface instead of Location in order to be able to override the Location entity properly?

Example (in Entity/ClickNCollectShippingMethod):
public function addLocation(Location $location): void

should be :

public function addLocation(LocationInterface $location): void
@dunglas
Copy link
Member

dunglas commented Apr 14, 2020

Good catch indeed! I'll fix this.

@dunglas dunglas mentioned this issue Apr 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to override the location entity coopTilleuls/CoopTilleulsSyliusClickNCollectPlugin
2 participants
@dunglas @davidroberto