Vault integration testing #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
topocount
force-pushed
the
vault-integration-testing
branch
from
9a21e4b
to
498f628
Compare
topocount
commented
Jun 6, 2022
|
Might be that we’re relying on react-query auto-refreshing due to
re-mounting a component? if so it could be sped up by explicitly calling
refetch once the work is done
…On Mon, Jun 6, 2022 at 1:16 PM Kevin Siegler ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In cypress/integration/createVault.ts
<#1004 (comment)>
:
> + // This takes extremely long time to render in the UI
+ // Not sure it's worth waiting two minutes for it to show up
+ //cy.contains('Distribution submitted today', { timeout: 240000 });
@levity <https://github.com/levity> @teeolendo
<https://github.com/teeolendo> I'm not sure how replicable this is yet in
a vanilla browser but it seems like something to watch.
—
Reply to this email directly, view it on GitHub
<#1004 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABPJA4QBIIS22WAOW7YBFLVNZMBBANCNFSM5YARUTCA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
topocount
force-pushed
the
vault-integration-testing
branch
from
815ca0f
to
548c16e
Compare
topocount
force-pushed
the
vault-integration-testing
branch
from
548c16e
to
cb8a6d0
Compare
topocount
force-pushed
the
vault-integration-testing
branch
2 times, most recently
from
a2c13c6
to
259908c
Compare
topocount
force-pushed
the
vault-integration-testing
branch
from
259908c
to
c2aa968
Compare
Codecov Report
@@ Coverage Diff @@
## main #1004 +/- ##
==========================================
- Coverage 28.18% 28.03% -0.15%
==========================================
Files 309 311 +2
Lines 6696 6763 +67
Branches 1744 1757 +13
==========================================
+ Hits 1887 1896 +9
- Misses 4798 4856 +58
Partials 11 11
Continue to review full report at Codecov.
|
Most of this work involved separating frontend code from web3 api semantics in order to prevent typecheck errors from mixing contexts
This includes Deployment, funding, and distribution creation
This should fix CI
topocount
force-pushed
the
vault-integration-testing
branch
from
c2aa968
to
4ec88e0
Compare
|
@levity or @teeolendo should i go ahead and merge this? |
levity
reviewed
Jun 13, 2022
levity
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes Deployment, funding, and distribution creation