-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand options for route_dir
#20
Comments
What is the alternative? However, it might be good to make it an array, so it can take multiple root directories. I could use this use case in one of my own projects. |
Shall I take the thumbsup as a "go ahead?" If so, I'll mark this as an enhancement. |
You can go ahead. Apart from that, I think that it's important to make route prefix configurable for each directory. |
We still need to implement configurable prefix per directory. I think that's best handled with a new enhancement issue. After the PR is accepted and merged, let's close this and open a new one for that with a reference. |
route_dir
optional?route_dir
Halfway on #20 - `routes_dir` accepts an array of parameters. - Updates documentation.
I can't update the npm package. Would you mind doing the release @sitraka-hq ? |
Also, did you happen to do some testing? I would like an independent party to verify it works properly. |
Found some disfunction. Testing and correcting. Undid the PR for now. Will update and re-submit. |
Ignore that ^ |
This functionality will be release with the #22. |
I tested your code and it was ok! I restored your change in #23. I also profited to update some dependencies. I think that everything is ok now! |
Oh, it does def have some issues. I tried it out in a project and it fell apart. I've since worked it out though. I'll be making a new push today. |
There are 3 possibilities:
route_dir
optionroute_dir
required and make it defaults toroutes
route_dir
can accept an array of directories where routes config can be loaded.The text was updated successfully, but these errors were encountered: