Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand options for route_dir #20

Closed
onoyr opened this issue Oct 25, 2019 · 11 comments
Closed

Expand options for route_dir #20

onoyr opened this issue Oct 25, 2019 · 11 comments
Assignees

Comments

@onoyr
Copy link
Contributor

onoyr commented Oct 25, 2019

There are 3 possibilities:

  • Force user to set the route_dir option
  • Make route_dir required and make it defaults to routes

route_dir can accept an array of directories where routes config can be loaded.

@onoyr onoyr added the question label Oct 25, 2019
@OneHoopyFrood
Copy link
Collaborator

What is the alternative? However, it might be good to make it an array, so it can take multiple root directories. I could use this use case in one of my own projects.

@OneHoopyFrood
Copy link
Collaborator

Shall I take the thumbsup as a "go ahead?" If so, I'll mark this as an enhancement.

@onoyr
Copy link
Contributor Author

onoyr commented Dec 2, 2019

You can go ahead. Apart from that, I think that it's important to make route prefix configurable for each directory.

@OneHoopyFrood
Copy link
Collaborator

OneHoopyFrood commented Dec 13, 2019

We still need to implement configurable prefix per directory. I think that's best handled with a new enhancement issue. After the PR is accepted and merged, let's close this and open a new one for that with a reference.

@OneHoopyFrood OneHoopyFrood changed the title Should route_dir optional? Expand options for route_dir Dec 13, 2019
onoyr added a commit that referenced this issue Dec 13, 2019
Halfway on #20

- `routes_dir` accepts an array of parameters.
- Updates documentation.
@onoyr onoyr closed this as completed Dec 13, 2019
@OneHoopyFrood
Copy link
Collaborator

I can't update the npm package. Would you mind doing the release @sitraka-hq ?

@OneHoopyFrood
Copy link
Collaborator

Also, did you happen to do some testing? I would like an independent party to verify it works properly.

@OneHoopyFrood OneHoopyFrood reopened this Dec 13, 2019
@OneHoopyFrood
Copy link
Collaborator

Found some disfunction. Testing and correcting. Undid the PR for now. Will update and re-submit.

OneHoopyFrood added a commit that referenced this issue Dec 13, 2019
@OneHoopyFrood
Copy link
Collaborator

Ignore that ^
Discovered the revert PR function too late. I did a reset on the master branch and force pushed. Won't do that again in the future, sorry.

@onoyr
Copy link
Contributor Author

onoyr commented Dec 16, 2019

I can't update the npm package. Would you mind doing the release @sitraka-hq ?

This functionality will be release with the #22.

onoyr added a commit that referenced this issue Dec 16, 2019
@onoyr
Copy link
Contributor Author

onoyr commented Dec 16, 2019

I tested your code and it was ok! I restored your change in #23. I also profited to update some dependencies.

I think that everything is ok now!

@OneHoopyFrood
Copy link
Collaborator

Oh, it does def have some issues. I tried it out in a project and it fell apart. I've since worked it out though. I'll be making a new push today.

onoyr added a commit that referenced this issue Jan 6, 2020
Implement enhancement for #20
@onoyr onoyr closed this as completed Jan 8, 2020
cooxe pushed a commit that referenced this issue Apr 22, 2024
Implement enhancement for #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants