Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple drafts support #71

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

multiple drafts support #71

wants to merge 2 commits into from

Conversation

yasser-sobhy
Copy link

@yasser-sobhy yasser-sobhy commented Jun 10, 2017

This is multiple drafts support for Draftsman.

Changes:

  • has_drafts now has a :multiple option if set to true Draftsman::Multiple::Draft will be used instead of Draftsman::Single::Draft
  • Draftsman::Multiple::Draft has has_drafts? method instead of draft?
  • For multiple drafts, every update is considered a draft, no updates to existing drafts
  • Draftsman::Multiple::Draft uses has_many association instead of belongs_to

To change:

  • Edit readme.md to reflect new changes
  • Review draft_publication_dependencies and draft_reversion_dependencies to make them work with multiple drafts or remove them if possible (actually I bypass them if :multiple option is true)
  • Make sure new changes passes all tests or add tests for new functionality

@chrisdpeters chrisdpeters added this to the 0.8 milestone Jun 12, 2017
@tvcam
Copy link

tvcam commented Dec 19, 2017

I've been waiting for this feature, when will it be released on 0.8 or merge to master?

@jmfederico
Copy link
Collaborator

Can you update the PR to resolve the conflicts?

@jmfederico
Copy link
Collaborator

This PR adds new functionality. Before merging or adding any new functionality, tests must be written for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants