Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting a function that requires modifiers, should map them if specified #29

Closed
fbergmann opened this issue Dec 13, 2022 · 2 comments
Closed

Comments

@fbergmann
Copy link
Member

When changing a function on a reaction, it should automatically add modifiers to the reaction scheme.

  • currently, when a reaction r1 with scheme A -> B is assigned a kinetic using modifiers this fails

In the gui, this is allowed, however, this results in an invalid function, since no mapping is specified at that point. I would rather want to avoid creating invalid states, as it would be hard to track down later.

So i propose to silently add modifiers to the reaction scheme, iff a mapping for modifier to species is defined. that means:

  • set_reaction('r1', function='function with modifier') would still fail, however
  • set_reaction('r1', function='function with modifier', mapping={'formulaTokenUsedAsModifier', 'speciesName' }) would work

@pmendes would that work for you?

@pmendes
Copy link
Member

pmendes commented Dec 13, 2022

@fbergmann I think that is the best solution, thanks.

@fbergmann
Copy link
Member Author

this has now been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants