accepted user commands and alerts are now registered as events #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By registering these low frequency events it will be possible later to check relevant actions and alerts that have been triggered for the system Also: * fixed bug in multi command alerts * CommandHandler.AlertFired has been removed, use CommandHandler.EventFired and check type == EventType.Alert instead
This comment has been minimized.
This comment has been minimized.
|
merging this as is for now, will address any review comments on a separate PR. |
freddyrios
added a commit
that referenced
this pull request
Oct 5, 2021
* breaking change: plugins run from the "plugins" subfolder reason: this allows to run without publishing the app as a single file, which at the time of writing allows to workaround dotnet/runtime#59961 * Also fixed regression in #127 preventing the full help from showing in the help command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By registering these low frequency events it will be possible later to check relevant actions and alerts that have been triggered for the system
Also: