New delta function has fix_symmetry set to "False"

[andbue]

If a new CompositeDeltaFunction is created, its fix_symmetry-attribute is for some reason set to "False".
Is this the expected behaviour?

[thvitt]

I don't quite get your question … fix_symmetry is a property of MetricDeltaFunction (which encapsulates a distance metric like those from scikit-learn), and it is only used in MetricDeltaFunction's __call__ method. CompositeDeltaFunction simply delegates to an existing (possibly Metric) DeltaFunction.

(In other words: Could you provide a problematic test case?)

[thvitt]

I still can't reproduce this. Here's a test:

pydelta/test/deltas_test.py

Lines 58 to 63 in f9e12b0

	def composite_metric_test(self):
	mcosine = d.MetricDeltaFunction('cosine', 'mcosine')
	assert mcosine.fix_symmetry == True, "fix_symmetry is False!?"
	mcd = d.CompositeDeltaFunction('mcosine-z_score', 'metric_cosine_delta')
	assert mcd.basis.fix_symmetry == True, "basis.fix_symmetry is False!?"
	self.check_function(d.functions.metric_cosine_delta, 0.6156353166442046)

[andbue]

Sorry, after restarting my jupyter kernel it works as expected. Must have been my own code's fault.
Thanks for looking into this issue anyway!