Allow multiline input #260

yajo · 2020-08-17T13:06:00Z

TODO:

Decide on a questionary toolkit: https://github.com/tmbo/questionary.
Fix tests to support TTy. Check how to test? prompt-toolkit/python-prompt-toolkit#1243 if the chosen toolkit is based on python-prompt-toolkit. See also Testing questionary flows tmbo/questionary#35.
Docs.
Test placeholder, templated.
Test when, templated.
Test multiline, templated and with str, json and yaml types.

Upstream PRs done by the way:

yajo · 2020-08-19T09:57:29Z

This PoC uses prompt-toolkit, and it looks quite nice until now, because it lets us to have live validation, multiline input and syntax highlighting.

Implementing choices, however, will be quite hard at least until prompt-toolkit/python-prompt-toolkit#1071 is fixed. Bool quiestions shouldn't be a problem, as bools are one simple kind of choices after all...

There are other simpler prompt toolkits which are all missing the multiline input feature. I opened a bunch of feature requests, and I will wait some time. If one of them implements it, it should be our toolkit of choice:

Multiline input bchao1/bullet#66
Multiline input feluxe/prmt#8
Multiline input tmbo/questionary#54
[feature-request] Command line input form and MultiSelect Prompt. prompt-toolkit/python-prompt-toolkit#1071
Feature request: multiline text magmax/python-inquirer#95, although if Do not fail if $EDITOR contains spaces rec/editor#1 is fixed and included in python-inquirer, the inquirer.Editor class could be enough (although Allow specifying suffix on Text questions magmax/python-inquirer#104 would help it being even better).
Allow multiline input with custom lexer CITGuru/PyInquirer#136.

If none does, then we'll have to choose one of those for all things except multiline inputs, and use prompt-toolkit just for those. But I'd rather prefer to stick with a single prompt toolkit if possible.

Fix #210.

…ompt

…ntexts

pawamoy · 2020-10-08T15:53:48Z

Well... I don't understand why the pip install fails either... Maybe try to restart the job 😕

Or could it be a cache issue?

I've tried that command on Windows:

 'C:\Program Files\Git\bin\bash.EXE' --noprofile --norc -e -o pipefail -c 'python -m pip install poetry poetry-dynamic-versioning poethepoet'

...and it went fine, even when the requirements were already satisfied.

yajo · 2020-10-09T09:03:57Z

Oh well, it seems you skipped some steps:

copier/.github/workflows/ci.yml

Lines 74 to 76 in 546ec8d

    
                     python -m pip install poetry poetry-dynamic-versioning poethepoet 
        
                     poetry run python -m pip install pip -U 
        
                     poetry install --verbose

The failure actually happens on the poetry install step, and it is probably related to python-poetry/poetry#3090 or python-poetry/poetry#3045.

pawamoy · 2020-10-09T09:53:33Z

Damn you're right! I'll try again.

pawamoy · 2020-10-09T10:08:03Z

I had some KeyError:

  1  c:\users\user\copier\venv\lib\site-packages\poetry\utils\env.py:1215 in _updated_path
     return os.pathsep.join([str(self._bin_dir), os.environ["PATH"]])

  KeyError

  'PATH'

...fixed with export PATH.

Then I got:

  Stack trace:

  7  c:\users\user\copier\venv\lib\site-packages\poetry\installation\executor.py:199 in _execute_operation
     result = self._do_execute_operation(operation)

  6  c:\users\user\copier\venv\lib\site-packages\poetry\installation\executor.py:273 in _do_execute_operation
     result = getattr(self, "_execute_{}".format(method))(operation)

  5  c:\users\user\copier\venv\lib\site-packages\poetry\installation\executor.py:408 in _execute_install
     return self._install(operation)

  4  c:\users\user\copier\venv\lib\site-packages\poetry\installation\executor.py:446 in _install
     return self.run_pip(*args)

  3  c:\users\user\copier\venv\lib\site-packages\poetry\installation\executor.py:297 in run_pip
     self._env.run_pip(*args, **kwargs)

  2  c:\users\user\copier\venv\lib\site-packages\poetry\utils\env.py:916 in run_pip
     return self._run(cmd, **kwargs)

  1  c:\users\user\copier\venv\lib\site-packages\poetry\utils\env.py:1189 in _run
     return super(VirtualEnv, self)._run(cmd, **kwargs)

  EnvCommandError

  Command C:\Users\user\copier\venv\Scripts\pip.exe install --no-deps C:\Users\user\AppData\Local\pypoetry\Cache\artifacts\58\cc\c2\a3eb325d94ba57a74146fd5692fb3876a9ff8d11985fdf1e35f389b0ee\jsbeautifier-1.13.0.tar.gz errored with the following return code 1, and output:
  Looking in indexes: redacted
  Processing c:\users\user\appdata\local\pypoetry\cache\artifacts\58\cc\c2\a3eb325d94ba57a74146fd5692fb3876a9ff8d11985fdf1e35f389b0ee\jsbeautifier-1.13.0.tar.gz
    Installing build dependencies: started
    Installing build dependencies: finished with status 'done'
    Getting requirements to build wheel: started
    Getting requirements to build wheel: finished with status 'done'
      Preparing wheel metadata: started
      Preparing wheel metadata: finished with status 'error'
      ERROR: Command errored out with exit status 1:
       command: 'c:\users\user\copier\venv\scripts\python.exe' 'c:\users\user\copier\venv\lib\site-packages\pip\_vendor\pep517\_in_process.py' prepare_metadata_for_build_wheel 'C:\Users\user\AppData\Local\Temp\1\tmpe2ua9ub0'
           cwd: C:\Users\user\AppData\Local\Temp\1\pip-req-build-806c5fbj
      Complete output (14 lines):
      running dist_info
      creating C:\Users\user\AppData\Local\Temp\1\pip-modern-metadata-ol72kxsp\jsbeautifier.egg-info
      writing C:\Users\user\AppData\Local\Temp\1\pip-modern-metadata-ol72kxsp\jsbeautifier.egg-info\PKG-INFO
      writing dependency_links to C:\Users\user\AppData\Local\Temp\1\pip-modern-metadata-ol72kxsp\jsbeautifier.egg-info\dependency_links.txt
      writing entry points to C:\Users\user\AppData\Local\Temp\1\pip-modern-metadata-ol72kxsp\jsbeautifier.egg-info\entry_points.txt
      writing requirements to C:\Users\user\AppData\Local\Temp\1\pip-modern-metadata-ol72kxsp\jsbeautifier.egg-info\requires.txt
      writing top-level names to C:\Users\user\AppData\Local\Temp\1\pip-modern-metadata-ol72kxsp\jsbeautifier.egg-info\top_level.txt
      writing manifest file 'C:\Users\user\AppData\Local\Temp\1\pip-modern-metadata-ol72kxsp\jsbeautifier.egg-info\SOURCES.txt'
      reading manifest file 'C:\Users\user\AppData\Local\Temp\1\pip-modern-metadata-ol72kxsp\jsbeautifier.egg-info\SOURCES.txt'
      reading manifest template 'MANIFEST.in'
      warning: no files found matching 'js-beautify'
      writing manifest file 'C:\Users\user\AppData\Local\Temp\1\pip-modern-metadata-ol72kxsp\jsbeautifier.egg-info\SOURCES.txt'
      creating 'C:\Users\user\AppData\Local\Temp\1\pip-modern-metadata-ol72kxsp\jsbeautifier.dist-info'
      error: invalid command 'bdist_wheel'
      ----------------------------------------
  ERROR: Command errored out with exit status 1: 'c:\users\user\copier\venv\scripts\python.exe' 'c:\users\user\copier\venv\lib\site-packages\pip\_vendor\pep517\_in_process.py' prepare_metadata_for_build_wheel 'C:\Users\user\AppData\Local\Temp\1\tmpe2ua9ub0' Check the logs for full command output.


  at c:\users\user\copier\venv\lib\site-packages\poetry\utils\env.py:948 in _run
       944│                 output = subprocess.check_output(
       945│                     cmd, stderr=subprocess.STDOUT, **kwargs
       946│                 )
       947│         except CalledProcessError as e:
    →  948│             raise EnvCommandError(e, input=input_)
       949│
       950│         return decode(output)
       951│
       952│     def execute(self, bin, *args, **kwargs):

...fixed with pip install wheel in the venv I'm using.

Then I got:

  Stack trace:

  7  c:\users\user\copier\venv\lib\site-packages\poetry\installation\executor.py:199 in _execute_operation
     result = self._do_execute_operation(operation)

  6  c:\users\user\copier\venv\lib\site-packages\poetry\installation\executor.py:273 in _do_execute_operation
     result = getattr(self, "_execute_{}".format(method))(operation)

  5  c:\users\user\copier\venv\lib\site-packages\poetry\installation\executor.py:408 in _execute_install
     return self._install(operation)

  4  c:\users\user\copier\venv\lib\site-packages\poetry\installation\executor.py:446 in _install
     return self.run_pip(*args)

  3  c:\users\user\copier\venv\lib\site-packages\poetry\installation\executor.py:297 in run_pip
     self._env.run_pip(*args, **kwargs)

  2  c:\users\user\copier\venv\lib\site-packages\poetry\utils\env.py:916 in run_pip
     return self._run(cmd, **kwargs)

  1  c:\users\user\copier\venv\lib\site-packages\poetry\utils\env.py:1189 in _run
     return super(VirtualEnv, self)._run(cmd, **kwargs)

  EnvCommandError

  Command C:\Users\user\copier\venv\Scripts\pip.exe install --no-deps C:\Users\user\AppData\Local\pypoetry\Cache\artifacts\9c\e3\a5\2336d6a7025672cb5036461b1bc4d7c9338cf89269e02b499c608ffe60\flake8-debugger-3.2.1.tar.gz errored with the following return code 1, and output:
  Looking in indexes: redacted
  Processing c:\users\user\appdata\local\pypoetry\cache\artifacts\9c\e3\a5\2336d6a7025672cb5036461b1bc4d7c9338cf89269e02b499c608ffe60\flake8-debugger-3.2.1.tar.gz
      ERROR: Command errored out with exit status 1:
       command: 'c:\users\user\copier\venv\scripts\python.exe' -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\\Users\\user\\AppData\\Local\\Temp\\1\\pip-req-build-f4kaly7v\\setup.py'"'"'; __file__='"'"'C:\\Users\\user\\AppData\\Local\\Temp\\1\\pip-req-build-f4kaly7v\\setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base 'C:\Users\user\AppData\Local\Temp\1\pip-pip-egg-info-7qvw3cyg'
           cwd: C:\Users\user\AppData\Local\Temp\1\pip-req-build-f4kaly7v\
      Complete output (25 lines):
      Download error on https://pypi.org/simple/pytest-runner/: Tunnel connection failed: 407 Proxy Authentication Required -- Some packages may not be found!
      Couldn't find index page for 'pytest-runner' (maybe misspelled?)
      Download error on https://pypi.org/simple/: Tunnel connection failed: 407 Proxy Authentication Required -- Some packages may not be found!
      No local packages or working download links found for pytest-runner
      Traceback (most recent call last):
        File "<string>", line 1, in <module>
        File "C:\Users\user\AppData\Local\Temp\1\pip-req-build-f4kaly7v\setup.py", line 60, in <module>
          'Programming Language :: Python :: 3.5',
        File "c:\users\user\copier\venv\lib\site-packages\setuptools\__init__.py", line 142, in setup
          _install_setup_requires(attrs)
        File "c:\users\user\copier\venv\lib\site-packages\setuptools\__init__.py", line 137, in _install_setup_requires
          dist.fetch_build_eggs(dist.setup_requires)
        File "c:\users\user\copier\venv\lib\site-packages\setuptools\dist.py", line 586, in fetch_build_eggs
          replace_conflicting=True,
        File "c:\users\user\copier\venv\lib\site-packages\pkg_resources\__init__.py", line 780, in resolve
          replace_conflicting=replace_conflicting
        File "c:\users\user\copier\venv\lib\site-packages\pkg_resources\__init__.py", line 1063, in best_match
          return self.obtain(req, installer)
        File "c:\users\user\copier\venv\lib\site-packages\pkg_resources\__init__.py", line 1075, in obtain
          return installer(requirement)
        File "c:\users\user\copier\venv\lib\site-packages\setuptools\dist.py", line 653, in fetch_build_egg
          return cmd.easy_install(req)
        File "c:\users\user\copier\venv\lib\site-packages\setuptools\command\easy_install.py", line 673, in easy_install
          raise DistutilsError(msg)
      distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('pytest-runner')
      ----------------------------------------
  ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.


  at c:\users\user\copier\venv\lib\site-packages\poetry\utils\env.py:948 in _run
       944│                 output = subprocess.check_output(
       945│                     cmd, stderr=subprocess.STDOUT, **kwargs
       946│                 )
       947│         except CalledProcessError as e:
    →  948│             raise EnvCommandError(e, input=input_)
       949│
       950│         return decode(output)
       951│
       952│     def execute(self, bin, *args, **kwargs):

...that I can't fix unfortunately. It seems flake8-debugger tries to download pytest-runner from PyPI, which is blocked by my corporate proxy.

…d remove poetry-dynamic-versioning from test workflow

… work.

See https://github.community/t/deprecated-add-path/136621/4?u=yajo

pawamoy · 2020-10-12T08:02:58Z

Congrats on this @yajo, it looked like hell to get it to work on Windows 😅 Sorry I couldn't help more!

yajo · 2020-10-12T20:05:12Z

Haha it really was! At the end I had to skip a lot of tests, but it seems to work fine.

yajo added the enhancement label Aug 17, 2020

yajo added this to the v6.0.0 milestone Aug 17, 2020

yajo force-pushed the improve-prompt branch from 05deee3 to feba1a1 Compare August 19, 2020 08:59

yajo force-pushed the improve-prompt branch from b609c95 to 78bcd76 Compare September 18, 2020 17:48

Allow multiline input

de95399

Fix #210.

yajo force-pushed the improve-prompt branch from 78bcd76 to de95399 Compare September 18, 2020 17:48

yajo self-assigned this Sep 18, 2020

yajo mentioned this pull request Sep 23, 2020

Handling of repo-level README.md OCA/oca-addons-repo-template#6

Closed

yajo force-pushed the improve-prompt branch from 4e1430e to ccfe4b2 Compare September 24, 2020 10:28

yajo marked this pull request as ready for review September 24, 2020 10:29

Use PyInquirer

5fe0683

yajo force-pushed the improve-prompt branch from ccfe4b2 to 5fe0683 Compare September 24, 2020 11:19

Jairo Llopis added 17 commits September 24, 2020 14:14

fixup! Use PyInquirer

ba14f16

fixup! Use PyInquirer

56e7f2b

fixup! Use PyInquirer

b5dafb6

fixup! Use PyInquirer

b27f561

fixup! Use PyInquirer

5b43159

fixup! Use PyInquirer

6669c44

Merge branch 'master' of github.com:copier-org/copier into improve-pr…

f19ec06

…ompt

update deps

0f39e31

Use pexpect to test new TUI

0f6b7cc

Merge branch 'master' of github.com:copier-org/copier into improve-pr…

b2f7af4

…ompt

Fix test_complex_questions

d41fc8c

fix test_templated_prompt_invalid

215be4a

Fix test

2f09988

Fix test_copy_default_advertised and add -n auto -ra in all pytest co…

459e3e0

…ntexts

Fix remaining tests

f0a59e7

Install from pypi

701ead2

fix

e46f432

fixup! Increase timeout for pexpect and use yaml.load_safe

2993b26

Update ci.yml

546ec8d

fixup! Update ci.yml

6735d15

Jairo Llopis and others added 6 commits October 9, 2020 12:31

Remove toml 0.5+ syntax (dotted keys)

fe7fbbc

Switch to poetry_core + poetry-dynamic-versioning as build system, an…

a1449fd

…d remove poetry-dynamic-versioning from test workflow

Use PopenSpawn for Windows compatibility

62f7cea

Increase timeout

a0adbd3

windows fixes

ac627f1

Change skip to xfail

aea2c4b

yajo mentioned this pull request Oct 11, 2020

how to test? prompt-toolkit/python-prompt-toolkit#1243

Open

Jairo Llopis added 4 commits October 11, 2020 10:12

fixup! Change skip to xfail

6c1f377

Remove deprecated add-path and set-env calls in CI

769d24d

Add kwargs to xfail

f303aab

xfail pexpect tests on windows. I'm tired of trying to make it work.

9f00bbc

yajo mentioned this pull request Oct 11, 2020

Testing questionary flows tmbo/questionary#35

Open

Jairo Llopis added 4 commits October 12, 2020 07:52

fixup! xfail pexpect tests on windows. I'm tired of trying to make it…

86a5e6b

… work.

Run pre-commit and mypy as tests

7495dca

Use inner poe

d4dec14

Remove dependencies from old times

0baab6e

yajo linked an issue Oct 12, 2020 that may be closed by this pull request

Conditional questions #161

Closed

Jairo Llopis added 2 commits October 12, 2020 08:33

Fix $PATH using powershell syntax

f208867

See https://github.community/t/deprecated-add-path/136621/4?u=yajo

Use powershell where syntax is compatible

66d34d1

yajo merged commit cda9327 into master Oct 12, 2020

yajo deleted the improve-prompt branch October 12, 2020 07:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow multiline input #260

Allow multiline input #260

yajo commented Aug 17, 2020 •

edited

Loading

yajo commented Aug 19, 2020 •

edited

Loading

pawamoy commented Oct 8, 2020 •

edited

Loading

yajo commented Oct 9, 2020 •

edited

Loading

pawamoy commented Oct 9, 2020

pawamoy commented Oct 9, 2020 •

edited

Loading

pawamoy commented Oct 12, 2020

yajo commented Oct 12, 2020

Allow multiline input #260

Allow multiline input #260

Conversation

yajo commented Aug 17, 2020 • edited Loading

yajo commented Aug 19, 2020 • edited Loading

pawamoy commented Oct 8, 2020 • edited Loading

yajo commented Oct 9, 2020 • edited Loading

pawamoy commented Oct 9, 2020

pawamoy commented Oct 9, 2020 • edited Loading

pawamoy commented Oct 12, 2020

yajo commented Oct 12, 2020

yajo commented Aug 17, 2020 •

edited

Loading

yajo commented Aug 19, 2020 •

edited

Loading

pawamoy commented Oct 8, 2020 •

edited

Loading

yajo commented Oct 9, 2020 •

edited

Loading

pawamoy commented Oct 9, 2020 •

edited

Loading