Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: convert package names to lowercase #753

Merged
merged 2 commits into from
Aug 28, 2022

Conversation

sisp
Copy link
Member

@sisp sisp commented Aug 26, 2022

I've converted all package names of dependencies to lowercase because I think it looks nicer and more consistent. Since the dependencies are sorted already, I infer these kinds of details also matter to you. 馃槈

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2022

Codecov Report

Merging #753 (80bb641) into master (1d6fb24) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #753   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files          41       41           
  Lines        2930     2930           
=======================================
  Hits         2831     2831           
  Misses         99       99           
Flag Coverage 螖
unittests 96.62% <酶> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pawamoy
Copy link
Contributor

pawamoy commented Aug 26, 2022

Me like. Slugified distribution names for the win.

Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe 馃槅 I see you love details.

@yajo
Copy link
Member

yajo commented Aug 28, 2022

Rebase please.

@sisp
Copy link
Member Author

sisp commented Aug 28, 2022

Hehe 馃槅 I see you love details.

Absolutely! 馃槅 But I think you do, too. Copier looks excellently written and maintained with an eye for details. 馃帀

Rebase please.

Done.

@yajo yajo enabled auto-merge (rebase) August 28, 2022 08:03
auto-merge was automatically disabled August 28, 2022 08:11

Rebase failed

@yajo yajo merged commit 29bc69a into copier-org:master Aug 28, 2022
@sisp sisp deleted the build/convert-package-names-to-lowercase branch August 28, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants