fix: ignore template repo tags that aren't valid PEP 440 versions #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In pypa/packaging#530 the packaging project stopped suplying legacy versions when a tag wasn't valid. Then, some repos started failing because they were relying on this. For example, see Tecnativa/doodba-copier-template#361. This change makes sure that invalid versions are skipped, so people can still update and those repos just keep working. The workaround until now is to specify a `--vcs-ref` option, to avoid Copier have to checkout the latest tag automatically (which is the code that triggers the bug). @moduon MT-2379
Codecov Report
@@ Coverage Diff @@
## master #989 +/- ##
==========================================
- Coverage 96.69% 96.52% -0.17%
==========================================
Files 42 42
Lines 3142 3164 +22
==========================================
+ Hits 3038 3054 +16
- Misses 104 110 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pypa/packaging#530 the packaging project stopped suplying legacy versions when a tag wasn't valid. Then, some repos started failing because they were relying on this.
For example, see Tecnativa/doodba-copier-template#361.
This change makes sure that invalid versions are skipped, so people can still update and those repos just keep working.
The workaround until now is to specify a
--vcs-refoption, to avoid Copier have to checkout the latest tag automatically (which is the code that triggers the bug).@moduon MT-2379