use number predicates

copiousfreetime · May 3, 2024 · b2a68d7 · b2a68d7
1 parent 2aea74f
commit b2a68d7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/lib/launchy/applications/browser.rb b/lib/launchy/applications/browser.rb
@@ -45,7 +45,7 @@ def browser_env
 
         browser_env = ENV["BROWSER"].split(File::PATH_SEPARATOR)
         browser_env.flatten!
-        browser_env.delete_if { |b| b.nil? || (b.strip.size == 0) }
+        browser_env.delete_if { |b| b.nil? || b.strip.size.zero? }
         return browser_env
       end
 

diff --git a/lib/launchy/argv.rb b/lib/launchy/argv.rb
@@ -27,7 +27,7 @@ def valid?
     end
 
     def blank?
-      @argv.empty? || (@argv.first.strip.size == 0)
+      @argv.empty? || @argv.first.strip.size.zero?
     end
 
     def executable?

diff --git a/lib/launchy/runner.rb b/lib/launchy/runner.rb
@@ -43,7 +43,7 @@ def shell_commands(cmd, args)
 
     def commandline_normalize(cmdline)
       c = cmdline.flatten!
-      c = c.find_all { |a| !a.nil? and (a.size > 0) }
+      c = c.find_all { |a| !a.nil? and a.size.positive? }
       Launchy.log "commandline_normalized => #{c.join(' ')}"
       return c
     end