Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternatives for when the link/url that is passed to open is invalid. #89

Closed
copiousfreetime opened this issue Sep 4, 2014 · 6 comments
Labels

Comments

@copiousfreetime
Copy link
Owner

It was brought up in StackOverflow that maybe Launchy could provide some mechanism to report if the url is invalid. This is a ticket to hold that discussion.

@abhinaykumar
Copy link

At this stage I feel Launchy should be able to handle or detect invalid urls may be through HTTP responses(like 200 for correct urls) or may be some other ways, it would be great if it doesn't raise this Error:: "Launchy::ApplicationNotFoundError: No application found to handle 'url' " everytime when you pass a wrong url or another feature could be like this, whenever you pass a url to Launchy it should either respond by opening a webpage (if url is valid) otherwise should show search results.(@copiousfreetime I dont know really if this kind of comment you were expecting, feel free to correct me if you see something wrong)

@copiousfreetime
Copy link
Owner Author

This is exactly the type of input I'm looking for 😄. I think I could definitely do some checking on the url and see if it is syntactically correct.

I might need a bit more convincing on doing a search item. Can you explain a bit more about that use case? What input are you giving launchy in this case and where are you getting that input from ?

@abhinaykumar
Copy link

sir, I dont want to waste your time i think it might not really "a feature to add" thing. But yeah coming on to the search items, well in that case I think even a top 5 results will do the job for me at least, but one thing which I would really love to see in it if I can actually tweak it to open a browser of my choice and show the output. Its something I am trying to learn by making some command line applications using ruby.I am unable to do this because Launchy simply opens firefox and I dont know where I should look to change its settings, but I think you can ignore these silly things please, search results is not really an important feature but I thought it could be a fun to have it inbuilt.

@copiousfreetime
Copy link
Owner Author

Launchy does its best to open your default browser and if it cannot figure that out, it tries some fallbacks.

If you want to explicitly specify which browser to use, you can set the BROWSER environment variable.

If you like you can also set the LAUNCHY_DEBUG=true in your environment and it will turn on debugging so you can see a bit how it decided to choose firefox.

I hope that helps.

@abhinaykumar
Copy link

👍

@copiousfreetime
Copy link
Owner Author

I think I'm going to close this as won't implement. the discussion happened and I think launchy does the right thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants