Add basic ANSI escape character control support #204
Conversation
Add support for readability in serial terminal Commands: ^[J - normally clears screen to the right, simply ignored here ^[H^[J - home cursor, clear screen to the right - clears textarea
src/browser/serial.js
Outdated
| else if(chr === "\r") | ||
| { | ||
| // do nothing | ||
| if(this.control_mode === false) { |
There was a problem hiding this comment.
Please follow the general style of the code ({ on an empty line after the )).
There was a problem hiding this comment.
I tried so hard to match the code style, it's nothing like my own. Will fix.
src/browser/serial.js
Outdated
| } | ||
| else if(cmds.invalid.test(this.control_buffer)) | ||
| { | ||
| this.control_mode = false; |
There was a problem hiding this comment.
Probably we should just add the escape sequence to the text here to make it easier to see when they're not handled.
src/browser/serial.js
Outdated
| var cmds = { | ||
| bksp: /$\[.J^/, | ||
| clr: /$\[.H\x1B\[.J^/, | ||
| invalid: /$*[^HJ]^/ |
There was a problem hiding this comment.
These don't look quite right:
$matches the end of the text and^the beginning- The
*ininvalidprobably requires something before it - I believe
invalidwould match before the other two; it needs to be more specific - Instead of the
., we should probably use a more specific match. This page says it can be 1, 2 or 3, so[123]might be more appropriate
There was a problem hiding this comment.
Whoops! I'm still getting the hang of regex. Silly mistakes.
|
Alright. I've made the requested changes. Let me know what you think. |
src/browser/serial.js
Outdated
| this.text = this.text.slice(0, -1); | ||
| this.update(); | ||
| } | ||
| else if(chr === "\x1b") { |
| var cmds = { | ||
| bksp: /^\[[0-2]?J$/, | ||
| clr: /^\[[0-9;]{0,5}H\x1b\[[0-2]?J$/, | ||
| invalid: /[hl=>0-2M-OmrA-Efg3-8KnRc8qy]/ |
There was a problem hiding this comment.
This is really hard to understand, can you find another way to find the end of the control buffer? If not, I can give this a shot.
Maybe a single regular expression could be used to match any sequence as described here:
The ESC [ is followed by any number (including none) of "parameter bytes" in the range 0x30–0x3F (ASCII 0–9:;<=>?), then by any number of "intermediate bytes" in the range 0x20–0x2F (ASCII space and !"#$%&'()*+,-./), then finally by a single "final byte" in the range 0x40–0x7E (ASCII @A–Z[]^_`a–z{|}~).
There was a problem hiding this comment.
We could go off of that spec. I created that regex for compatibility with VT-100 commands as well. If need be I will fix it.
There was a problem hiding this comment.
I might just wait for this PR to go through and write a new version of this file with screen memory so I can implement more commands
|
Alright @copy. Maybe this time. I’m working on a new branch with screen memory so I can implement complex commands. |
Currency
|
Closing as no progress in 3 months. |
Add support for readability in serial terminal
Commands:
^[J - normally clears screen to the right, simply ignored here
^[H^[J - home cursor, clear screen to the right - clears textarea