Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HADDPS instruction #837

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Implement HADDPS instruction #837

merged 1 commit into from
Apr 19, 2023

Conversation

rameshvarun
Copy link
Contributor

This PR adds the HADDPS instruction, which fixes this issue. This allows the KolibriOS Raytracing demo to run. Numeric exceptions aren't implemented.

Documentation:

@copy
Copy link
Owner

copy commented Apr 19, 2023

Thanks! Should be good to merge after running cargo fmt --all.

@rameshvarun
Copy link
Contributor Author

I'm currently on cargo 1.71.0-nightly (d0a4cbcee 2023-04-16). cargo fmt --all gives me a much larger diff - https://pastebin.mozilla.org/3fHiGA9Y

Unsure if the formatting logic in cargo changed recently. In any case, there don't seem to be any formatting changes WRT to the lines of this PR.

@copy copy merged commit 38a103c into copy:master Apr 19, 2023
2 checks passed
@copy
Copy link
Owner

copy commented Apr 19, 2023

In any case, there don't seem to be any formatting changes WRT to the lines of this PR.

Indeed, I misread the indentation on github. All good, merged! Cheers.

@copy copy mentioned this pull request Apr 24, 2023
5 tasks
@copy copy mentioned this pull request May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KolibriOS Raytracing Demo Crashes due to missing sse3 support
2 participants