Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove structured data from templates #23

Closed
nickcernis opened this issue Feb 28, 2018 · 3 comments
Closed

Remove structured data from templates #23

nickcernis opened this issue Feb 28, 2018 · 3 comments

Comments

@nickcernis
Copy link
Contributor

As reported at https://wordpress.org/support/topic/structured-data-problem-using-this-plugin-and-woocommerce-3-x/, WooCommerce 3 switched to JSON LD for structured data.

https://github.com/woocommerce/woocommerce/wiki/2.6.x-to-3.0.0-Developer-Migration-Notes#product-schema-markup-moved-to-json-ld-format

The schema markup in our product templates therefore causes errors in Google's structured data testing tool, because WooCommerce 3 no longer outputs expected schema output in tags such as product headings:

screen shot on 2018-02-28 at 09 38 00

Under Woo 2.6.14 the markup looked like this and was valid:

screen shot on 2018-02-28 at 09 37 32

I suggest we drop the schema markup from product templates and make WooCommerce 3 the minimum recommended compatible version.

@nickcernis
Copy link
Contributor Author

nickcernis commented Jun 12, 2018

To test:

Confirm:

  • Product is detected, with correct data for the product.
  • Product contains no errors or warnings, as below.

structured-data-test-results

@nickcernis
Copy link
Contributor Author

Confirmed ×1 in WP.org forums:

https://wordpress.org/support/topic/schema-error-3/#post-10478384

@swa433
Copy link

swa433 commented Jul 10, 2018

@nickcernis Confirmed +1
(product is detected, with correct data & without any error/warning related to product)

Environment:
WordPress:
Version: 4.9.7

PHP:
Versions: 5.6.24 & 7.1.14

Genesis Framework:
Version: 2.6.1

Genesis Sample (active theme):
Version: 2.6.0

WooCommerce:
Version: 3.4.3

Genesis Connect for WooCommerce:
Version: 0.9.10
Issue reproducible!

Genesis Connect for WooCommerce:
Version: 0.9.11 ( https://github.com/copyblogger/genesis-connect-woocommerce )
Issue fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants