-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distribute Coq 8.11 (etc.) as from the alpha phase #3
Comments
This is great, but I believe this means that this means that the Docker image will use the dune-based OPAM file in the Coq repository, which is subtly different from the non-dune build of Coq. For example, I don't think the dune build supports bytecode currently (not a problem in my projects). Just a heads up to document this on the wiki. |
Dear @palmskog,
Ah OK! thanks for the remark, I was not aware of that :-/ so indeed the following files are different:
OK; but to overcome this opam config difference (and even if the Dune-based build is going to supersede the make-based build system very soon), do you think that a small PR modifying the |
@ejgallego can likely correct any details I get wrong here, but my understanding from asking around is that the opam file in the Coq repo is used for benchmarking (coq-bench), while the one in the opam archive repo is what users are supposed to generally use for installation. These files may become in synch at some future point when the release managers fully commit to using dune (which did not happen for 8.11). Dune can then even generate the opam file, so it doesn't have to live in the repo. I believe coq-bench is still used on the |
I'm not sure what you mean but it should support bytecode right; only difference is support for native compute and that plugins are built differently but the new way is more robust. I'm unsure how to solve this OPAM discrepancy problem. |
Hi @ejgallego and @palmskog, OK thanks for your feedback! so let's say we keep the two opam files as is for now, and in any case that issue will disappear with the beta (as it will rely on the core-dev opam file, not on the git branch) |
Right, I mixed up bytecode and native compute. Indeed the opam discrepancy shouldn't be a blocker for an experimental Docker image, so I agree with @erikmd here. |
Sounds good @erikmd , we should really remove the discrepancy tho. |
Done (closing the issue now):
FYI I wrote this in the wiki:
(but feel free to suggest another phrasing if need be) |
As suggested by @palmskog on Gitter:
I've started looking into, this looks definitely feasible! but I guess I won't rely on the
8.11.dev
opamcore-dev
package (because in each Docker images, two different switches are built sequentially, so there is a small risk that the Coq version between the two switches is different 😃), fortunately I can reuse the setup I had written for thecoq.dev
nightly refreshing Docker image − basically, using somebuild
Docker Hub hook + some opam git pinning:I'll close that issue as soon as the image is ready and the wiki updated, hopefully in a couple of hours.
The text was updated successfully, but these errors were encountered: