Merge PR #18448: Fixes #18434: arguments of --external in coqdoc were…

… inadvertently swapped Reviewed-by: silene Ack-by: ppedrot Co-authored-by: silene <silene@users.noreply.github.com>
coq · Jan 9, 2024 · 50ca6d5 · 50ca6d5
2 parents df68f04 + efd6634
commit 50ca6d5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/doc/changelog/09-cli-tools/18448-master+fix18434-coqdoc-external-regression.rst b/doc/changelog/09-cli-tools/18448-master+fix18434-coqdoc-external-regression.rst
@@ -0,0 +1,6 @@
+- **Fixed:**
+  Regression in option :g:`--external` of `coqdoc`, whose two arguments
+  were inadvertently swapped
+  (`#18448 <https://github.com/coq/coq/pull/18448>`_,
+  fixes `#18434 <https://github.com/coq/coq/issues/18434>`_,
+  by Hugo Herbelin).
diff --git a/tools/coqdoc/cmdArgs.ml b/tools/coqdoc/cmdArgs.ml
@@ -180,7 +180,7 @@ let args_options = Arg.align [
   "--verbose", arg_set (fun p -> { p with quiet = false }), " Verbose mode";
   "--no-externals", arg_set (fun p -> { p with externals = false }),
   " No links to Coq standard library";
-  "--external", arg_url_path Index.add_external_library,
+  "--external", arg_url_path (fun url lp -> Index.add_external_library lp url),
   "<url>+<d> set URL for external library <d>";
   "--coqlib_url", arg_string (fun p u -> { p with coqlib_url = u }),
   "<url> Set URL for Coq standard library (default: " ^ Coq_config.wwwstdlib ^ ")";