Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Azure MacOS version 10.13 -> 10.14 #11803

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Update Azure MacOS version 10.13 -> 10.14 #11803

merged 1 commit into from
Mar 13, 2020

Conversation

SkySkimmer
Copy link
Contributor

10.13 is deprecated as an azure VM

Close #11449

@SkySkimmer SkySkimmer requested a review from a team as a code owner March 11, 2020 13:26
@ejgallego ejgallego self-assigned this Mar 12, 2020
ejgallego
ejgallego approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@ejgallego ejgallego left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that should be fine, we do build the OSX images here do we?

Can someone test the artifact at https://dev.azure.com/coq/coq/_build/results?buildId=8082&view=artifacts&type=publishedArtifacts ?

@ejgallego ejgallego added kind: infrastructure CI, build tools, development tools. needs: testing Some manual testing is required. labels Mar 12, 2020
@ejgallego ejgallego added this to the 8.11.1 milestone Mar 12, 2020
@Zimmi48
Copy link
Member

Zimmi48 commented Mar 12, 2020

cc @herbelin
I think he has a pretty old macOS version, so would be a perfect candidate for testing the installer.

@herbelin
Copy link
Member

When trying to install the file coq-8.12+alpha-installer-macos.dmg linked above, I get (translated to English): Impossible to open the disk image, no mountable file system.

Note: I'm on MacOS 10.11.1.

@ejgallego
Copy link
Member

Note: I'm on MacOS 10.11.1.

@herbelin does the one here work https://dev.azure.com/coq/coq/_build/results?buildId=8123&view=artifacts&type=publishedArtifacts ?

@herbelin
Copy link
Member

@herbelin does the one here work https://dev.azure.com/coq/coq/_build/results?buildId=8123&view=artifacts&type=publishedArtifacts ?

Yes, it installs perfectly, and I could Check True. in CoqIDE!

@ejgallego
Copy link
Member

Thanks @herbelin , thus the PR seems to break the image, I'm afraid we need more help from an OSX expert; actually this is kind of critical as azure will remove the old image in 12 days!

@ejgallego ejgallego added the priority: high The priority for inclusion in the next release is high. label Mar 12, 2020
@Zimmi48
Copy link
Member

Zimmi48 commented Mar 13, 2020

cc @MSoegtropIMC who is not yet an OSX expert but is learning about it.

@herbelin
Copy link
Member

herbelin commented Mar 13, 2020 •
edited
Loading

It seems that adding option -fs hfs+ to the call to hdiutil in dev/build/osx/make-macos-dmg.sh would make the package work for versions of MacOS < 10.2.

If I understand the information on the web correctly, MacOS 10.4 (Mojave) uses by default a different file system, APFS, replacing the HFS+ default. APFS is recognized only from MacOS 10.2 (High Sierra).

Since the exact choice of file system does not a priori matter for the CoqIDE dmg, staying with HFS+ seems a good solution.

@SkySkimmer: could you try adding the option and restarting?

@SkySkimmer
Update Azure MacOS version 10.13 -> 10.14
ac25e20 
10.13 is deprecated as an azure VM

Close coq#11449
@ejgallego
Copy link
Member

Thanks @herbelin @SkySkimmer ; Hugo, can you try the image at https://dev.azure.com/coq/coq/_build/results?buildId=8155&view=artifacts&type=publishedArtifacts

@herbelin
Copy link
Member

It works!

@ejgallego
Copy link
Member

Great, thanks a lot for all the testing @herbelin

@ejgallego ejgallego removed help wanted needs: testing Some manual testing is required. labels Mar 13, 2020
@ejgallego ejgallego merged commit 2ea5dc1 into coq:master Mar 13, 2020
@SkySkimmer SkySkimmer deleted the update-azure-mac branch March 14, 2020 12:09
ppedrot added a commit to ppedrot/coq that referenced this pull request Mar 20, 2020
@ppedrot
Backport PR coq#11803: Update Azure MacOS version 10.13 -> 10.14
d334d96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejgallego ejgallego ejgallego approved these changes

Assignees

@ejgallego ejgallego

Labels
kind: infrastructure CI, build tools, development tools. priority: high The priority for inclusion in the next release is high.
Projects
None yet
Milestone
8.11.1
Development

Successfully merging this pull request may close these issues.

azure macos 10.13 deprecated
4 participants
@SkySkimmer @Zimmi48 @herbelin @ejgallego