-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Univ declarations can have extensible qualities (internally) #19073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coqbot-app
bot
added
the
needs: full CI
The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI.
label
May 22, 2024
@coqbot run full ci |
coqbot-app
bot
removed
the
needs: full CI
The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI.
label
May 22, 2024
ppedrot
reviewed
May 22, 2024
SkySkimmer
added
kind: fix
This fixes a bug or incorrect documentation.
request: full CI
Use this label when you want your next push to trigger a full CI.
labels
May 27, 2024
SkySkimmer
changed the title
UState: don't check for unbound qualities as it doesn't make sense
Univ declarations can have extensible qualities (internally)
May 27, 2024
SkySkimmer
force-pushed
the
abstract-sort-poly
branch
from
May 27, 2024 13:04
7d74a5b
to
90e31e2
Compare
coqbot-app
bot
removed
the
request: full CI
Use this label when you want your next push to trigger a full CI.
label
May 27, 2024
ppedrot
approved these changes
May 27, 2024
ppedrot
added
the
needs: overlay
This is breaking external developments we track in CI.
label
May 27, 2024
Not supported in syntax as due to collapsing qualities any quality we see must be named, but side effects use default_univ_decl which must allow the named qualities from the surrounding proof. Fix coq#19072
SkySkimmer
added a commit
to SkySkimmer/coq-elpi
that referenced
this pull request
May 29, 2024
SkySkimmer
added
request: full CI
Use this label when you want your next push to trigger a full CI.
and removed
needs: overlay
This is breaking external developments we track in CI.
labels
May 29, 2024
SkySkimmer
force-pushed
the
abstract-sort-poly
branch
from
May 29, 2024 13:29
90e31e2
to
435896b
Compare
coqbot-app
bot
removed
the
request: full CI
Use this label when you want your next push to trigger a full CI.
label
May 29, 2024
ping @ppedrot |
@coqbot merge now |
@ppedrot: Please take care of the following overlays:
|
ppedrot
added a commit
to LPCIC/coq-elpi
that referenced
this pull request
Jun 4, 2024
Adapt to coq/coq#19073 (univdecl_extensible_qualities)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not supported in syntax as due to collapsing qualities any quality we
see must be named, but side effects use default_univ_decl which must
allow the named qualities from the surrounding proof.
Fix #19072
Overlays: