Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Univ declarations can have extensible qualities (internally) #19073

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

SkySkimmer
Copy link
Contributor

@SkySkimmer SkySkimmer commented May 22, 2024

Not supported in syntax as due to collapsing qualities any quality we
see must be named, but side effects use default_univ_decl which must
allow the named qualities from the surrounding proof.

Fix #19072

Overlays:

@SkySkimmer SkySkimmer requested a review from a team as a code owner May 22, 2024 13:15
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label May 22, 2024
@ppedrot ppedrot self-assigned this May 22, 2024
@ppedrot
Copy link
Member

ppedrot commented May 22, 2024

@coqbot run full ci

@coqbot-app coqbot-app bot removed the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label May 22, 2024
engine/uState.ml Outdated Show resolved Hide resolved
@SkySkimmer SkySkimmer added kind: fix This fixes a bug or incorrect documentation. request: full CI Use this label when you want your next push to trigger a full CI. labels May 27, 2024
@SkySkimmer SkySkimmer changed the title UState: don't check for unbound qualities as it doesn't make sense Univ declarations can have extensible qualities (internally) May 27, 2024
@SkySkimmer SkySkimmer requested review from a team as code owners May 27, 2024 13:04
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label May 27, 2024
@ppedrot ppedrot added this to the 8.20+rc1 milestone May 27, 2024
@ppedrot ppedrot added the needs: overlay This is breaking external developments we track in CI. label May 27, 2024
Not supported in syntax as due to collapsing qualities any quality we
see must be named, but side effects use default_univ_decl which must
allow the named qualities from the surrounding proof.

Fix coq#19072
SkySkimmer added a commit to SkySkimmer/coq-elpi that referenced this pull request May 29, 2024
@SkySkimmer SkySkimmer added request: full CI Use this label when you want your next push to trigger a full CI. and removed needs: overlay This is breaking external developments we track in CI. labels May 29, 2024
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label May 29, 2024
@proux01
Copy link
Contributor

proux01 commented Jun 4, 2024

ping @ppedrot

@ppedrot
Copy link
Member

ppedrot commented Jun 4, 2024

@coqbot merge now

@coqbot-app coqbot-app bot merged commit 344c7b4 into coq:master Jun 4, 2024
6 checks passed
Copy link
Contributor

coqbot-app bot commented Jun 4, 2024

@ppedrot: Please take care of the following overlays:

  • 19073-SkySkimmer-abstract-sort-poly.sh

ppedrot added a commit to LPCIC/coq-elpi that referenced this pull request Jun 4, 2024
@SkySkimmer SkySkimmer deleted the abstract-sort-poly branch June 4, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: fix This fixes a bug or incorrect documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

abstract tactic doesn't work when the top-level proof is sort-polymorphic
3 participants