ppvernac fixes (univdecl incorrect printing and attribute spacing) #19095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkySkimmer
added
the
needs: merge of dependency
coqbot-app
bot
added
the
needs: full CI
proux01
removed
the
needs: merge of dependency
SkySkimmer
added
kind: user messages
silene
reviewed
Jun 4, 2024
vernac/ppvernac.ml
Outdated
| @@ -83,24 +88,30 @@ let pr_cumul_univdecl_instance l extensible = | |||
|
|
|||
| let pr_univdecl_constraints l extensible = | |||
| if List.is_empty l && extensible then mt () | |||
| else str"|" ++ spc () ++ prlist_with_sep (fun () -> strbrk" | ") pr_uconstraint l ++ | |||
| else strbrk" | " ++ prlist_with_sep (fun () -> strbrk", ") pr_uconstraint l ++ | |||
There was a problem hiding this comment.
Suggested change
| else strbrk" | " ++ prlist_with_sep (fun () -> strbrk", ") pr_uconstraint l ++ | |
| else strbrk" | " ++ prlist_with_sep pr_comma pr_uconstraint l ++ |
Also, unless you insist on breaking before the pipe, you can use pr_spcbar () in place of strbrk" | ".
|
@coqbot run full ci |
coqbot-app
bot
removed
the
needs: full CI
proux01
approved these changes
Jun 10, 2024
|
@coqbot merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends