-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated attribute needs to be refined #8075
Comments
+1 |
TBH I'm not sure we want to have |
That makes sense, why not adopting this simplification. Do we target 8.9 or 8.10? How to proceed? |
You target master for sure. You can put it in the 8.9.0 milestone if you want. Then the debate of whether it is backported or not can happen with the RM after the PR has been merged (or just before if this changes where to put the CHANGES entry). |
Indeed, sounds reasonable. I'm otherwise a bit lost in who wants to be involved. Should we make an "attributes" maintainer group? Or maybe, the current de facto status, i.e. that attributes are under the supervision of @SkySkimmer is ok for anyone? Please anyone involved express his position. |
Should be solved now
What do we want to do with this?
Now that we use |
The deprecated attribute can be applied to any vernacular command, but it only has an effect on Ltac definitions. It is bad to not give an error message, or at least a warning, when it is applied on a command that is not supported.
Both the
since=
andnote=
sub-attributes are optional but you need to provide at least one of them. This doesn't make much sense. Note that providingnote=""
is not the same as not providingnote
because the printing won't be the same (more spaces in the former case). The same is true forsince=""
vs nosince
.The text was updated successfully, but these errors were encountered: