Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print Assumptions spuriously reports axioms from module types defined in another file #8416

Closed
jtassarotti opened this issue Sep 5, 2018 · 2 comments · Fixed by #8417
Closed
Milestone

Comments

@jtassarotti
Copy link

Version 8.8.1

Operating system: Linux

Description of the problem

Define the following in a file "test.v":

Module Type A.
  Axiom f : True.
End A.

Module M : A.
  Lemma f : True. trivial. Qed. 
End M.

Then, if we have in another file

Require Import test.

Lemma test : True.
Proof. apply M.f. Qed.

Module N : A.
  Lemma f : True. trivial. Qed. 
End N.

Lemma test2 : True.
Proof. apply N.f. Qed.

Print Assumptions test.
Print Assumptions test2.

The first print assumption command claims there's an axiom:

Axioms:
M.f : True

while the second properly reports that the term is closed under the global context. Under 8.8.0, both are reported as closed. This is causing lots of spurious assumptions to be listed in my developments that use mathcomp libraries.

@ejgallego
Copy link
Member

Confirmed on master.

herbelin added a commit to herbelin/github-coq that referenced this issue Sep 5, 2018
…mpiled files).

This fixes the fix 1522b98 to coq#7192.

The remaining Not_found after 1522b98 should have rung a bell that
something was still strange.
herbelin added a commit to herbelin/github-coq that referenced this issue Sep 5, 2018
…mpiled files).

This fixes the fix 1522b98 to coq#7192.

The remaining Not_found after 1522b98 should have rung a bell that
something was still strange.
herbelin added a commit to herbelin/github-coq that referenced this issue Sep 5, 2018
…mpiled files).

This fixes the fix 1522b98 to coq#7192.

The remaining Not_found after 1522b98 should have rung a bell that
something was still strange.
@herbelin
Copy link
Member

herbelin commented Sep 5, 2018

This was introduced in 1522b98 (my bad) which itself was conversely fixing a problem with missing constraints. See a fix at #8417.

mattam82 added a commit that referenced this issue Sep 10, 2018
@Zimmi48 Zimmi48 added this to the 8.8.2 milestone Sep 10, 2018
Zimmi48 pushed a commit that referenced this issue Sep 11, 2018
…led files).

This fixes the fix 1522b98 to #7192.

The remaining Not_found after 1522b98 should have rung a bell that
something was still strange.

(cherry picked from commit 899f3eb)
Zimmi48 pushed a commit that referenced this issue Sep 11, 2018
herbelin added a commit to herbelin/github-coq that referenced this issue Sep 23, 2018
The regression was introduced in 1522b98 (PR coq#7193) which itself was
fixing bug coq#7192. (Note another regression of the same commit which is
fixed in coq#8416.)
herbelin added a commit to herbelin/github-coq that referenced this issue Sep 25, 2018
The regression was introduced in 1522b98 (PR coq#7193) which itself was
fixing bug coq#7192. (Note another regression of the same commit which is
fixed in coq#8416.)
Zimmi48 pushed a commit to Zimmi48/coq that referenced this issue Sep 25, 2018
The regression was introduced in 1522b98 (PR coq#7193) which itself was
fixing bug coq#7192. (Note another regression of the same commit which is
fixed in coq#8416.)

(cherry picked from commit 1ac3418)
Zimmi48 pushed a commit to Zimmi48/coq that referenced this issue Sep 25, 2018
The regression was introduced in 1522b98 (PR coq#7193) which itself was
fixing bug coq#7192. (Note another regression of the same commit which is
fixed in coq#8416.)

(cherry picked from commit 1ac3418)
Zimmi48 pushed a commit to Zimmi48/coq that referenced this issue Sep 28, 2018
…mpiled files).

This fixes the fix 1522b98 to coq#7192.

The remaining Not_found after 1522b98 should have rung a bell that
something was still strange.

(cherry picked from commit 899f3eb)
Zimmi48 pushed a commit to Zimmi48/coq that referenced this issue Sep 28, 2018
The regression was introduced in 1522b98 (PR coq#7193) which itself was
fixing bug coq#7192. (Note another regression of the same commit which is
fixed in coq#8416.)

(cherry picked from commit 1ac3418)
Zimmi48 pushed a commit to Zimmi48/coq that referenced this issue Sep 28, 2018
…mpiled files).

This fixes the fix 1522b98 to coq#7192.

The remaining Not_found after 1522b98 should have rung a bell that
something was still strange.

(cherry picked from commit 899f3eb)
Zimmi48 pushed a commit to Zimmi48/coq that referenced this issue Sep 28, 2018
The regression was introduced in 1522b98 (PR coq#7193) which itself was
fixing bug coq#7192. (Note another regression of the same commit which is
fixed in coq#8416.)

(cherry picked from commit 1ac3418)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants