A temporary fix of #13018 and #12775 for branch 8.12 (bis) #13073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We arbitrarily use max_int as higher level of custom entries in printing, which should be ok since only < and <= are used to decide when to use coercions.
herbelin
added
kind: fix
|
@coqbot: merge now |
2 tasks
herbelin
added a commit
to herbelin/github-coq
that referenced
this pull request
Jul 3, 2021
informations about the subentries: we remember whether we are at any level, at the next level or at the self level. Incidentally, we also take into account option Printing Parentheses in custom entries. This is a more principled fix to coq#12775/coq#13018 than coq#13073 (printing bugs in custom entry rules with no explicit level).
herbelin
added a commit
to herbelin/github-coq
that referenced
this pull request
Oct 22, 2021
informations about the subentries: we remember whether we are at any level, at the next level or at the self level. Incidentally, we also take into account option Printing Parentheses in custom entries. This is a more principled fix to coq#12775/coq#13018 than coq#13073 (printing bugs in custom entry rules with no explicit level).
herbelin
added a commit
to herbelin/github-coq
that referenced
this pull request
Jan 14, 2023
informations about the subentries: we remember whether we are at any level, at the next level or at the self level. Incidentally, we also take into account option Printing Parentheses in custom entries. This is a more principled fix to coq#12775/coq#13018 than coq#13073 (printing bugs in custom entry rules with no explicit level). Compared to "subentries", the name "entry_relative" insists on the syntactic structure of the type rather than on its semantic origin, since, after all, subentries are promoted as entries in the recursive printing loop.
3 tasks
herbelin
added a commit
to herbelin/github-coq
that referenced
this pull request
Jan 17, 2023
informations about the subentries: we remember whether we are at any level, at the next level or at the self level. Incidentally, we also take into account option Printing Parentheses in custom entries. This is a more principled fix to coq#12775/coq#13018 than coq#13073 (printing bugs in custom entry rules with no explicit level). Compared to "subentries", the name "entry_relative" insists on the syntactic structure of the type rather than on its semantic origin, since, after all, subentries are promoted as entries in the recursive printing loop.
proux01
pushed a commit
to herbelin/github-coq
that referenced
this pull request
Feb 15, 2023
informations about the subentries: we remember whether we are at any level, at the next level or at the self level. Incidentally, we also take into account option Printing Parentheses in custom entries. This is a more principled fix to coq#12775/coq#13018 than coq#13073 (printing bugs in custom entry rules with no explicit level). Compared to "subentries", the name "entry_relative" insists on the syntactic structure of the type rather than on its semantic origin, since, after all, subentries are promoted as entries in the recursive printing loop.
proux01
pushed a commit
to herbelin/github-coq
that referenced
this pull request
May 30, 2023
informations about the subentries: we remember whether we are at any level, at the next level or at the self level. Incidentally, we also take into account option Printing Parentheses in custom entries. This is a more principled fix to coq#12775/coq#13018 than coq#13073 (printing bugs in custom entry rules with no explicit level). Compared to "subentries", the name "entry_relative" insists on the syntactic structure of the type rather than on its semantic origin, since, after all, subentries are promoted as entries in the recursive printing loop.
proux01
pushed a commit
to herbelin/github-coq
that referenced
this pull request
May 30, 2023
informations about the subentries: we remember whether we are at any level, at the next level or at the self level. Incidentally, we also take into account option Printing Parentheses in custom entries. This is a more principled fix to coq#12775/coq#13018 than coq#13073 (printing bugs in custom entry rules with no explicit level). Compared to "subentries", the name "entry_relative" insists on the syntactic structure of the type rather than on its semantic origin, since, after all, subentries are promoted as entries in the recursive printing loop.
This was referenced Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind: bug fix
This redoes #13026 on top of master (after #13026 was itself moved on top of branch v8.12).
Fixes #12775
Fixes #13018