Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI failure] Fix bad interaction between merging of #13664 and #14598 #14836

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

proux01
Copy link
Contributor

@proux01 proux01 commented Sep 1, 2021

We should have rerun CI before merging #13664, this would have avoided
missing that #13664 forgot to take #14598 into account.

This should fix the test-suite jobs in the CI that are broken since the merging of #13664

We should have rerun CI before merging coq#13664, this would have avoided
missing that coq#13664 forgot to take coq#14598 into account.
@coqbot-app
Copy link
Contributor

coqbot-app bot commented Sep 2, 2021

Hey, I have detected that there were CI failures at commit e63ee29 without any failure in the test-suite.
I checked that the corresponding jobs for the base commit 6bd07ba succeeded. You can ask me to try to extract a minimal test case from this so that it can be added to the test-suite.
If you tag me saying @coqbot ci minimize all, I will additionally minimize the following target (which I do not suggest minimizing): ci-category_theory (because base job at 6bd07ba failed)

@proux01 proux01 changed the title Fix bad interaction between merging of #13664 and #14598 [CI failure] Fix bad interaction between merging of #13664 and #14598 Sep 2, 2021
@ppedrot
Copy link
Member

ppedrot commented Sep 2, 2021

That's a duplicate of #14834 but since I have merge rights, that nobody cared about the other one and that fixing the test-suite is urgent, I'll merge this right now and close the other one.

@ppedrot ppedrot added the kind: infrastructure CI, build tools, development tools. label Sep 2, 2021
@ppedrot ppedrot added this to the 8.15+rc1 milestone Sep 2, 2021
@ppedrot ppedrot self-assigned this Sep 2, 2021
@ppedrot ppedrot merged commit 6685a40 into coq:master Sep 2, 2021
@proux01 proux01 deleted the fix_13664_after_14598 branch September 2, 2021 08:46
@proux01
Copy link
Contributor Author

proux01 commented Sep 2, 2021

@ppedrot sorry, I somehow missed #14834 (and I don't (yet) have merge rights anyway ;) )
Well, thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: infrastructure CI, build tools, development tools.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants