Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namegen.next_ident_away_in_goal: avoid names of all visible refs #15077

Closed

Conversation

SkySkimmer
Copy link
Contributor

Fix #3523

Considering the large stdlib changes this is probably not feasible, but let's see CI

@SkySkimmer SkySkimmer requested review from a team as code owners October 27, 2021 12:56
@JasonGross
Copy link
Member

Can we write a script to automate this process? E.g., have a setting that makes every top-level destruct and induction statement without an as clause whose naming behavior changes as a result of this PR emit a warning of the form "Name change upcoming, replace with destruct XXX as YYY to keep the old names", and then I can code up a python script that does the replacements based on the warning logs

@github-actions github-actions bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Oct 28, 2021
@SkySkimmer
Copy link
Contributor Author

Breaks too much to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Names autogenerated by [destruct] should not depend on whether or not the type was defined in the same file.
2 participants