Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct module document #15125

Merged
merged 8 commits into from Nov 12, 2021
Merged

Correct module document #15125

merged 8 commits into from Nov 12, 2021

Conversation

akr
Copy link
Contributor

@akr akr commented Nov 5, 2021

I corrected several small problems in
doc/sphinx/language/core/modules.rst .

@akr akr requested a review from a team as a code owner November 5, 2021 14:09
The conclusion of WF-MOD2 was WF(E; Mod(X:S1[:=S2]))[].

But S2 should not be optional.

In the case that S2 is not given here,
WF-MOD2 is same as WF-MOD1 with meaningless premises for S2.

coq@81f1219
changes the macro \Mod as:

-\newcommand{\Mod}[3]{{\sf Mod}({coq#1}:{coq#2}:={coq#3})}
+\newcommand{\Mod}[3]{{\sf Mod}({coq#1}:{coq#2}\,\zeroone{:={coq#3}})}

So, "[" and "]" added in WF-MOD2 seems accidental.
Copy link
Contributor

@Alizter Alizter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Zimmi48 Zimmi48 self-assigned this Nov 12, 2021
@Zimmi48 Zimmi48 added kind: documentation Additions or improvement to documentation. kind: fix This fixes a bug or incorrect documentation. labels Nov 12, 2021
@Zimmi48 Zimmi48 added this to the 8.14.1 milestone Nov 12, 2021
Copy link
Member

@Zimmi48 Zimmi48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, and sorry for the delay in handling this.

@coqbot merge now

@coqbot-app coqbot-app bot merged commit 1a57401 into coq:master Nov 12, 2021
@coqbot-app coqbot-app bot added this to Request 8.14.1 inclusion in Coq 8.14 Nov 12, 2021
@Zimmi48
Copy link
Member

Zimmi48 commented Nov 12, 2021

By the way, @akr, we're aware that the section on modules is not the best organized in the Coq reference manual. So if you happen to have suggestions for larger changes, do not hesitate to propose them.

@akr akr deleted the module-doc branch November 13, 2021 20:17
silene added a commit to silene/coq that referenced this pull request Nov 19, 2021
@coqbot-app coqbot-app bot moved this from Request 8.14.1 inclusion to Shipped in 8.14.1 in Coq 8.14 Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: documentation Additions or improvement to documentation. kind: fix This fixes a bug or incorrect documentation.
Projects
No open projects
Coq 8.14
Shipped in 8.14.1
Development

Successfully merging this pull request may close these issues.

None yet

3 participants