Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Universal Lemma Under Conjunction flag (deprecated in 8.15). #15268

Merged
merged 2 commits into from Dec 6, 2021
Merged

Remove Universal Lemma Under Conjunction flag (deprecated in 8.15). #15268

merged 2 commits into from Dec 6, 2021

Conversation

Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Nov 29, 2021 •
edited

  • Added / updated test-suite.
  • Added changelog.
  • Added / updated documentation.

@Zimmi48 Zimmi48 mentioned this pull request Nov 30, 2021
Merged
2 tasks
@github-actions github-actions bot added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Dec 1, 2021
@Zimmi48 Zimmi48 force-pushed the test-remove-univ-lemma-under-conj branch from 7cecd82 to cae5799 Compare December 1, 2021 18:01
@coqbot-app coqbot-app bot removed the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Dec 1, 2021
@Zimmi48 Zimmi48 added kind: cleanup Code removal, deprecation, refactorings, etc. needs: changelog entry This should be documented in doc/changelog. labels Dec 1, 2021
@Zimmi48 Zimmi48 added this to the 8.16+rc1 milestone Dec 1, 2021
@Zimmi48 Zimmi48 changed the title Test removing Universal Lemma Under Conjunction flag. Remove Universal Lemma Under Conjunction flag (deprecated in 8.15). Dec 3, 2021
@Zimmi48 Zimmi48 marked this pull request as ready for review December 3, 2021 11:14
@Zimmi48 Zimmi48 requested review from a team as code owners December 3, 2021 11:14
@ppedrot ppedrot self-assigned this Dec 3, 2021
@Zimmi48 Zimmi48 removed the needs: changelog entry This should be documented in doc/changelog. label Dec 3, 2021
jfehrle
jfehrle approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@jfehrle jfehrle left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

doc/changelog/07-vernac-commands-and-options/15268-test-remove-univ-lemma-under-conj.rst Show resolved Hide resolved
@ppedrot
Copy link
Member

ppedrot commented Dec 6, 2021

@Zimmi48 do you want to tweak the changelog before I merge?

@Zimmi48
Copy link
Member Author

Zimmi48 commented Dec 6, 2021

I'm not convinced by the suggested change.

@ppedrot
Copy link
Member

ppedrot commented Dec 6, 2021

OK, let's merge then.

@ppedrot
Copy link
Member

ppedrot commented Dec 6, 2021

@coqbot merge now

@coqbot-app coqbot-app bot merged commit 3534b55 into coq:master Dec 6, 2021
@Zimmi48 Zimmi48 deleted the test-remove-univ-lemma-under-conj branch December 6, 2021 19:46
@andres-erbsen andres-erbsen mentioned this pull request Feb 20, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppedrot ppedrot ppedrot approved these changes

@jfehrle jfehrle jfehrle approved these changes

Assignees

@ppedrot ppedrot

Labels
kind: cleanup Code removal, deprecation, refactorings, etc.
Projects
None yet
Milestone
8.16+rc1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zimmi48 @ppedrot @jfehrle