deprecate Cd command #16119
Closed
deprecate Cd command #16119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
This was referenced Mar 16, 2023
|
@herbelin @SkySkimmer There was this plan to deprecate Cd entirely because it was only used in extraction. It might help with the output directory PR. If you disallow output directory and Cd to be used, it might simplofy the implementation. We can deprecate Cd as extraction can now have its output directory set IIRC. That was the only blocker. |
|
Oh I see that you've already seen this so nevermind then. |
|
@herbelin I won't have time to work on this so feel free to take over. I just wanted to make sure you knew about it. |
herbelin
added a commit
to herbelin/github-coq
that referenced
this pull request
Mar 29, 2024
… Directory. New attempt to Alizter's PR coq#16119.
herbelin
added a commit
to herbelin/github-coq
that referenced
this pull request
Apr 2, 2024
… Directory. New attempt to Alizter's PR coq#16119.
herbelin
added a commit
to herbelin/github-coq
that referenced
this pull request
Apr 5, 2024
… Directory. New attempt to Alizter's PR coq#16119.
herbelin
added a commit
to herbelin/github-coq
that referenced
this pull request
Apr 18, 2024
… Directory. New attempt to Alizter's PR coq#16119.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping this as a draft for now. We need to provide output directory support for extraction first.