Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] Avoid deprecation warnings in OCaml 5.0 #17015

Merged
merged 1 commit into from Dec 22, 2022

Conversation

ejgallego
Copy link
Member

This should have make world working in OCaml 5.0

This should have `make world` working in OCaml 5.0
@ejgallego ejgallego requested a review from a team as a code owner December 21, 2022 23:18
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Dec 21, 2022
@ppedrot
Copy link
Member

ppedrot commented Dec 22, 2022

I'm assigning and merging because this is a trivial tweak.

@ppedrot ppedrot self-assigned this Dec 22, 2022
@ppedrot ppedrot added kind: internal API, ML documentation... and removed needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. labels Dec 22, 2022
@ppedrot ppedrot added this to the 8.17+rc1 milestone Dec 22, 2022
@ppedrot
Copy link
Member

ppedrot commented Dec 22, 2022

@coqbot merge now

@coqbot-app
Copy link
Contributor

coqbot-app bot commented Dec 22, 2022

@ppedrot: You can't merge the PR because it hasn't been approved yet.

@ppedrot
Copy link
Member

ppedrot commented Dec 22, 2022

@coqbot merge now

@coqbot-app coqbot-app bot merged commit 97f9c65 into coq:master Dec 22, 2022
@coqbot-app coqbot-app bot added this to Request 8.17+rc1 inclusion in Coq 8.17 Dec 22, 2022
Zimmi48 added a commit to Zimmi48/coq that referenced this pull request Dec 22, 2022
@ejgallego ejgallego deleted the build+ocaml5_warn branch December 22, 2022 18:45
@coqbot-app coqbot-app bot moved this from Request 8.17+rc1 inclusion to Shipped to 8.17+rc1 in Coq 8.17 Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: internal API, ML documentation...
Projects
No open projects
Coq 8.17
Shipped to 8.17+rc1
Development

Successfully merging this pull request may close these issues.

None yet

2 participants