Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for string constant tokens in notations #17123

Merged
merged 4 commits into from
Jul 16, 2023
Merged

Support for string constant tokens in notations #17123

merged 4 commits into from
Jul 16, 2023

Commits on Jul 7, 2023

  1. In passing, using String.plural when possible in notation.ml.

    @herbelin
    herbelin committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    13aff42 View commit details
    Browse the repository at this point in the history

  2. Adding a function to quote strings according to Coq convention.

    @herbelin
    herbelin committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    18a8da3 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. Support for recognizing string constants tokens in notations. 

    We follow the same principle as numbers:
- string constants can be used as part of notations
- if parsing articulation points, string constants can be set as keywords

Note that isolated double quotes, as in ``Notation "a "" b" := ...''
are (still) not permitted (they would be considered as the start of an
unterminated string by the lexer).

Co-authored-by: Jim Fehrle <jim.fehrle@gmail.com>
    @herbelin @jfehrle @proux01
    2 people authored and proux01 committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    385381a View commit details
    Browse the repository at this point in the history

  2. Adding change log for coq#17123 

    Co-authored-by: Jim Fehrle <jim.fehrle@gmail.com>
    @herbelin @jfehrle @proux01
    2 people authored and proux01 committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    71738f3 View commit details
    Browse the repository at this point in the history