Fixes #17583: regression using numerals in the syntax of tactic notations #17589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herbelin
added
kind: fix
coqbot-app
bot
removed
the
request: full CI
|
As a superficial comment, this looks very hackish to me, even for Ltac1. |
|
You mean that the criterion for deciding when a keyword is needed is hackish? In some sense, yes, it is hackish counterpart of not having a more local treatment of keywords. Regarding the code, otherwise, I would say that it should be factorized in one central place (except that GADT and different Term/NonTerm types make it difficult to factorize). |
ppedrot
reviewed
Feb 28, 2024
herbelin
force-pushed
the
master+fix17583-regression-using-numerals-in-tactic-notation
branch
from
2e79185
to
b0091de
Compare
coqbot-app
bot
added
the
needs: full CI
herbelin
added a commit
to herbelin/github-coq
that referenced
this pull request
Feb 29, 2024
herbelin
force-pushed
the
master+fix17583-regression-using-numerals-in-tactic-notation
branch
from
b0091de
to
cc04085
Compare
After an ident, it does not need (see Metasyntax.make_production for the similar computation in constr): after another terminal, it does not need.
herbelin
force-pushed
the
master+fix17583-regression-using-numerals-in-tactic-notation
branch
from
cc04085
to
1f13c98
Compare
|
What are we doing with this? |
|
I answered @ppedrot's remark I think. Now, the PR seen as fixing a regression passed over 3 versions probably, so maybe not any more so important either. |
|
Let's close thus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / closes #17583.
We are a bit less eager to define every terminal of a
Tactic Notationas a keyword, following what we already did forNotation.We make a patch also for
Ltac2 Notationwhich had the same limitation (Ltac2 developers: tell if this is ok).