Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ltac1 and Ltac2: don't normalize evars for open_constr:() #17704

Merged
merged 1 commit into from Nov 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions doc/changelog/04-tactics/17704-open-constr-no-expand.rst
@@ -0,0 +1,6 @@
- **Changed:**
`open_constr` in Ltac1 and Ltac2 does not perform evar normalization.
Normalization may be recovered using `let c := open_constr:(...) in constr:(c)`
if necessary for performance
(`#17704 <https://github.com/coq/coq/pull/17704>`_,
by Gaëtan Gilbert).
4 changes: 2 additions & 2 deletions plugins/ltac/tacinterp.ml
Expand Up @@ -632,7 +632,7 @@ let open_constr_use_classes_flags () = {
use_typeclasses = UseTC;
solve_unification_constraints = true;
fail_evar = false;
expand_evars = true;
expand_evars = false;
program_mode = false;
polymorphic = false;
}
Expand All @@ -642,7 +642,7 @@ let open_constr_no_classes_flags () = {
use_typeclasses = NoUseTC;
solve_unification_constraints = true;
fail_evar = false;
expand_evars = true;
expand_evars = false;
program_mode = false;
polymorphic = false;
}
Expand Down
2 changes: 1 addition & 1 deletion plugins/ltac2/tac2core.ml
Expand Up @@ -39,7 +39,7 @@ let open_constr_no_classes_flags =
use_typeclasses = Pretyping.NoUseTC;
solve_unification_constraints = true;
fail_evar = false;
expand_evars = true;
expand_evars = false;
program_mode = false;
polymorphic = false;
}
Expand Down