Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #17782: anomaly when trying to disable a non existing custom notation #17891

Conversation

herbelin
Copy link
Member

A trivial fix.

Fixes / closes #17782

  • Added / updated test-suite.
  • Added changelog.

@herbelin herbelin added kind: fix This fixes a bug or incorrect documentation. part: notations The notation system. labels Jul 26, 2023
@herbelin herbelin added this to the 8.18.0 milestone Jul 26, 2023
@herbelin herbelin requested review from a team as code owners July 26, 2023 15:16
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jul 26, 2023
herbelin added a commit to herbelin/github-coq that referenced this pull request Jul 26, 2023
@herbelin herbelin force-pushed the master+fix17782-anomaly-disable-non-existing-custom-notation branch from 7f3382b to 14f33f8 Compare July 26, 2023 15:18
@ppedrot
Copy link
Member

ppedrot commented Jul 26, 2023

@herbelin your PR contains unrelated commits.

@herbelin herbelin force-pushed the master+fix17782-anomaly-disable-non-existing-custom-notation branch from 14f33f8 to 560c689 Compare July 26, 2023 17:11
@herbelin
Copy link
Member Author

Thanks. Fixed.

@herbelin
Copy link
Member Author

@coqbot run full ci

@coqbot-app coqbot-app bot removed the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jul 31, 2023
@proux01
Copy link
Contributor

proux01 commented Aug 2, 2023

@coqbot merge now

@coqbot-app
Copy link
Contributor

coqbot-app bot commented Aug 2, 2023

@proux01: You cannot merge this PR because:

  • You are not among the assignees.

@proux01 proux01 self-assigned this Aug 2, 2023
@proux01
Copy link
Contributor

proux01 commented Aug 2, 2023

@coqbot merge now

@coqbot-app coqbot-app bot merged commit cf41421 into coq:master Aug 2, 2023
7 checks passed
@Zimmi48 Zimmi48 added this to Request 8.18.0 inclusion in Coq 8.18 Aug 13, 2023
@gares gares modified the milestones: 8.18.0, 8.19+rc1 Aug 31, 2023
@Zimmi48 Zimmi48 removed this from Request 8.18.0 inclusion in Coq 8.18 Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: fix This fixes a bug or incorrect documentation. part: notations The notation system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anomaly when disabling a previously unbound notation in a custom grammar
4 participants