Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #17071: appropriate error instead of anomaly in the presence of notations with constructors applied to too many arguments in pattern-matching #17892

Conversation

herbelin
Copy link
Member

A rather simple fix: turning the failure into a proper error message.

Fixes / closes #17071

  • Added / updated test-suite.
  • Added changelog.

@herbelin herbelin added kind: fix This fixes a bug or incorrect documentation. part: notations The notation system. labels Jul 26, 2023
@herbelin herbelin added this to the 8.18.0 milestone Jul 26, 2023
@herbelin herbelin requested a review from a team as a code owner July 26, 2023 17:13
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jul 26, 2023
@herbelin
Copy link
Member Author

@coqbot run full ci

@coqbot-app coqbot-app bot removed the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jul 31, 2023
@proux01 proux01 self-assigned this Aug 2, 2023
@proux01
Copy link
Contributor

proux01 commented Aug 2, 2023

@coqbot merge now

@coqbot-app coqbot-app bot merged commit 30554d5 into coq:master Aug 2, 2023
7 checks passed
@Zimmi48 Zimmi48 added this to Request 8.18.0 inclusion in Coq 8.18 Aug 13, 2023
@gares gares modified the milestones: 8.18.0, 8.19+rc1 Aug 31, 2023
@Zimmi48 Zimmi48 removed this from Request 8.18.0 inclusion in Coq 8.18 Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: fix This fixes a bug or incorrect documentation. part: notations The notation system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anomaly "Uncaught exception Failure("List.skipn")."
3 participants