Fixes #11237: support constructor with parameters in primitive notations for patterns #17902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herbelin
added
kind: fix
coqbot-app
bot
removed
the
request: full CI
Zimmi48
reviewed
Jul 31, 2023
… patterns. Additionally, we restructurate the code a bit, moving the check on well-formedness of patterns in constrintern.ml so that the separation of roles between check_allowed_ref_in_pat (just check the validity so that another interpretation can be taken if it fails) and rcp_of_pat (which interpret the pattern) is clearer. We also check that the "in" clause of "match" accepts a notation for inductive type at the head.
herbelin
force-pushed
the
master+fix11237-constructor-parameters-in-prim-notation-for-pattern
branch
from
60d0f6b
to
ac165b4
Compare
coqbot-app
bot
added
the
needs: full CI
Merged
2 tasks
|
@coqbot run full ci |
coqbot-app
bot
removed
the
needs: full CI
proux01
approved these changes
Aug 3, 2023
|
@coqbot merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixed by forcing the parameters of the constructors to be
_when coming from a notation.We also provide support for a notation at the head of an "in" clause of "match".
Fixes / closes #11237