Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some minor results about single-step behavior of nth_error #17998

Merged
merged 2 commits into from Sep 2, 2023
Merged

Add some minor results about single-step behavior of nth_error #17998

merged 2 commits into from Sep 2, 2023

Conversation

JasonGross
Copy link
Member

@JasonGross JasonGross commented Aug 31, 2023 •
edited

  • Added changelog.

@JasonGross JasonGross requested a review from a team as a code owner August 31, 2023 20:51
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Aug 31, 2023
@andres-erbsen andres-erbsen self-assigned this Aug 31, 2023
@JasonGross JasonGross added this to the 8.19+rc1 milestone Aug 31, 2023
@JasonGross JasonGross added the request: full CI Use this label when you want your next push to trigger a full CI. label Aug 31, 2023
@coqbot-app coqbot-app bot removed request: full CI Use this label when you want your next push to trigger a full CI. needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. labels Aug 31, 2023
@JasonGross JasonGross added the request: full CI Use this label when you want your next push to trigger a full CI. label Sep 1, 2023
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Sep 1, 2023
@JasonGross JasonGross added part: standard library The standard library stdlib. kind: enhancement Enhancement to an existing user-facing feature, tactic, etc. labels Sep 1, 2023
@andres-erbsen
Copy link
Contributor

Metacoq timeout also appears on master https://github.com/coq/coq/runs/16427207787

@andres-erbsen
Copy link
Contributor

@coqbot merge now

@coqbot-app coqbot-app bot merged commit a50fc93 into coq:master Sep 2, 2023
7 of 9 checks passed
@Zimmi48
Copy link
Member

Zimmi48 commented Sep 3, 2023

Metacoq timeout also appears on master https://github.com/coq/coq/runs/16427207787

Indeed. It is likely related to the migration to Inria GitLab CI, and probably means that we should bump this timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andres-erbsen andres-erbsen andres-erbsen approved these changes

Assignees

@andres-erbsen andres-erbsen

Labels
kind: enhancement Enhancement to an existing user-facing feature, tactic, etc. part: standard library The standard library stdlib.
Projects
None yet
Milestone
8.19+rc1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JasonGross @andres-erbsen @Zimmi48