New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize more paths in coqdep to avoid spurious warnings #18165
Conversation
1ac7501
to
69ca0e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me but I'm not a coqdep expert.
@ejgallego @Alizter I think you are more up to date on coqdep, any objections?
We need to make sure this works correctly on windows. Are we testing Coq platform for windows in the CI? |
Thanks @rlepigre , I was actually looking into this the other day; the "right" fix would be to have Coq stopping to set [Basically you want to move from the current setup where Happy to have this in Coq meanwhile. Regarding testing, I think using |
Patch is an improvement over the current situation. |
@coqbot run full ci |
@coqbot merge now |
This fixes warnings such as the following: