Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for weak cbv #18190

Merged
merged 6 commits into from Nov 21, 2023
Merged

Support for weak cbv #18190

merged 6 commits into from Nov 21, 2023

Conversation

herbelin
Copy link
Member

@herbelin herbelin commented Oct 21, 2023

This is a variant of @maximedenes' weak-cbv branch providing a weak cbv strategy of reduction of the CIC call-by-name theory. In there, free variables are considered as "constructors", so that x t evaluates to x t' where t' is the weak-head normal form of t.

It should be useful for #17503 (give access to the "weak" form of reduction strategies).

@herbelin herbelin added kind: enhancement Enhancement to an existing user-facing feature, tactic, etc. part: reduction strategies The Strategy command for defining reduction straegies. labels Oct 21, 2023
@herbelin herbelin added this to the 8.19+rc1 milestone Oct 21, 2023
@herbelin herbelin requested review from a team as code owners October 21, 2023 06:43
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Oct 21, 2023
@herbelin herbelin added the request: full CI Use this label when you want your next push to trigger a full CI. label Oct 25, 2023
@herbelin herbelin requested a review from a team as a code owner October 25, 2023 18:17
@coqbot-app coqbot-app bot removed request: full CI Use this label when you want your next push to trigger a full CI. needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. labels Oct 25, 2023
@herbelin
Copy link
Member Author

herbelin commented Oct 25, 2023

Binding of weak cbv to reduction strategy cbv head done.

Ideally, more tests could be done though [Added: done].

Copy link
Member

@jfehrle jfehrle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wording suggestions

doc/changelog/04-tactics/17503-redexpr.rst Outdated Show resolved Hide resolved
doc/changelog/04-tactics/17503-redexpr.rst Outdated Show resolved Hide resolved
doc/sphinx/proofs/writing-proofs/equality.rst Show resolved Hide resolved
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Oct 27, 2023
@herbelin herbelin added the request: full CI Use this label when you want your next push to trigger a full CI. label Oct 27, 2023
@coqbot-app coqbot-app bot removed request: full CI Use this label when you want your next push to trigger a full CI. needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. labels Oct 27, 2023
@herbelin herbelin added the request: full CI Use this label when you want your next push to trigger a full CI. label Oct 28, 2023
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Oct 28, 2023
@coqbot-app
Copy link
Contributor

coqbot-app bot commented Oct 28, 2023

The job library:ci-fiat_crypto_legacy has failed in allow failure mode
ping @JasonGross

@SkySkimmer SkySkimmer self-assigned this Nov 7, 2023
Copy link
Contributor

@SkySkimmer SkySkimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs rebase (sort poly was merged)

@SkySkimmer SkySkimmer added the needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. label Nov 7, 2023
herbelin and others added 6 commits November 15, 2023 19:24
We block under lam, fix and the return clause and branches of match.

However free variables are considered as constructors, i.e. we reduce
"x t" info "x t'" where t' is the whd of t.
Include some rephrasing in doc, co-authored by Jim.

Co-Authored-By: Jim Fehrle <jim.fehrle@gmail.com>
@coqbot-app coqbot-app bot added needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. and removed needs: rebase Should be rebased on the latest master to solve conflicts or have a newer CI run. labels Nov 15, 2023
@herbelin
Copy link
Member Author

@coqbot run full ci

@coqbot-app coqbot-app bot removed the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Nov 15, 2023
@SkySkimmer
Copy link
Contributor

@coqbot merge now

@coqbot-app coqbot-app bot merged commit 7cf5e39 into coq:master Nov 21, 2023
6 of 10 checks passed
Copy link
Contributor

coqbot-app bot commented Nov 21, 2023

@SkySkimmer: Please take care of the following overlays:

  • 18190-herbelin-master+weak-cbv.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Enhancement to an existing user-facing feature, tactic, etc. part: reduction strategies The Strategy command for defining reduction straegies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants