Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ssr] Stop relying on camlp5 recovery mechanism #18224

Merged
merged 3 commits into from Mar 14, 2024

Conversation

proux01
Copy link
Contributor

@proux01 proux01 commented Oct 30, 2023

Stop relying on camlp5/coqpp recovery mechanism for "do [tac] => intro" and "tac; [tac|..|tac] => intro"

This is in preparation of #17876

  • Added / updated test-suite.
  • Added changelog.
  • Added / updated documentation.
    • Documented any new / changed user messages.
    • Updated documented syntax by running make doc_gram_rsts.
  • Opened overlay pull requests.

Overlays (to be merged before the current PR)

Overlays (to be merged in sync with the current PR)

@proux01 proux01 requested a review from a team as a code owner October 30, 2023 13:22
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Oct 30, 2023
@herbelin
Copy link
Member

By the way, the notations .1 and .2 are extremely standard and should be reserved in Init (even if whether they apply to prod or sigT is not standardized... somehow we should eventually find a way to overload the notations for prod and sigT...).

@proux01 proux01 added the request: full CI Use this label when you want your next push to trigger a full CI. label Oct 30, 2023
@proux01 proux01 requested a review from a team as a code owner October 30, 2023 15:32
@coqbot-app coqbot-app bot removed request: full CI Use this label when you want your next push to trigger a full CI. needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. labels Oct 30, 2023
@coqbot-app
Copy link
Contributor

coqbot-app bot commented Oct 31, 2023

The job library:ci-fiat_crypto_legacy has failed in allow failure mode
ping @JasonGross

@herbelin
Copy link
Member

Note: as future work for the notation system, we could think at how to define a notation x . N on lists or n-tuples which stands for hd (tl .. (tl x) ..) repeated N times. Something like:

Notation "x . N" := (hd (tl .. (tl x) ..)) (N meta-natural).

or maybe

Notation "x . N" := (hd (iter N tl x)) (eval iter on fixed N).

@proux01
Copy link
Contributor Author

proux01 commented Oct 31, 2023

FWIW It's probably already possible to get something like (fun x => hd (tl ... (tl x)) x using number notations.

@coq coq deleted a comment from coqbot-app bot Oct 31, 2023
@coq coq deleted a comment from coqbot-app bot Oct 31, 2023
@coq coq deleted a comment from coqbot-app bot Oct 31, 2023
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Nov 2, 2023
@proux01
Copy link
Contributor Author

proux01 commented Nov 3, 2023

@coqbot run full ci

@coqbot-app coqbot-app bot removed the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Nov 3, 2023
Copy link
Contributor

coqbot-app bot commented Nov 3, 2023

The job library:ci-fiat_crypto_legacy has failed in allow failure mode
ping @JasonGross

Copy link
Contributor

coqbot-app bot commented Nov 3, 2023

🔴 CI failures at commit 49b25ce without any failure in the test-suite

✔️ Corresponding jobs for the base commit 2af3ead succeeded

❔ Ask me to try to extract minimal test cases that can be added to the test-suite

🏃 @coqbot ci minimize will minimize the following targets: ci-analysis, ci-equations, ci-iris, ci-perennial
  • You can also pass me a specific list of targets to minimize as arguments.
  • If you tag me saying @coqbot ci minimize all, I will additionally minimize the following target (which I do not suggest minimizing): ci-fiat_crypto_legacy (because base job at 2af3ead failed)

⚠️ ⌛ You may want to wait until the pipeline for the base commit (2af3ead) finishes.

proux01 added a commit to proux01/Coq-Equations that referenced this pull request Nov 10, 2023
proux01 added a commit to proux01/analysis that referenced this pull request Nov 10, 2023
proux01 added a commit to proux01/analysis that referenced this pull request Nov 10, 2023
proux01 added a commit to math-comp/analysis that referenced this pull request Nov 10, 2023
proux01 added a commit to math-comp/analysis that referenced this pull request Nov 10, 2023
@proux01 proux01 added part: notations The notation system. part: ssreflect The SSReflect proof language. kind: enhancement Enhancement to an existing user-facing feature, tactic, etc. labels Nov 10, 2023
@proux01 proux01 added the request: full CI Use this label when you want your next push to trigger a full CI. label Feb 5, 2024
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Feb 5, 2024
@coq coq deleted a comment from coqbot-app bot Feb 5, 2024
@proux01 proux01 added the request: full CI Use this label when you want your next push to trigger a full CI. label Feb 6, 2024
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Feb 6, 2024
@proux01
Copy link
Contributor Author

proux01 commented Feb 6, 2024

@coq/ssreflect-maintainers this is finally ready (windows failure in CI is unrelated)

@ppedrot
Copy link
Member

ppedrot commented Feb 12, 2024

Let's explicitly ping @gares, I think this is an important foundational PR.

@ppedrot
Copy link
Member

ppedrot commented Mar 14, 2024

Ping @gares for assignee again, the sooner this is merged the better I think.

@proux01
Copy link
Contributor Author

proux01 commented Mar 14, 2024

This s mostly a three lines PR, it shouldn't take much time to look at.

@gares gares self-assigned this Mar 14, 2024
@gares gares added this to the 8.20+rc1 milestone Mar 14, 2024
@gares
Copy link
Member

gares commented Mar 14, 2024

@coqbot merge now

@coqbot-app coqbot-app bot merged commit 0f0f505 into coq:master Mar 14, 2024
5 of 6 checks passed
Copy link
Contributor

coqbot-app bot commented Mar 14, 2024

@gares: Please take care of the following overlays:

  • 18224-proux01-ssr_17876.sh

gares added a commit to LPCIC/coq-elpi that referenced this pull request Mar 14, 2024
@proux01 proux01 deleted the ssr_17876 branch March 14, 2024 12:30
@SkySkimmer
Copy link
Contributor

This seems to be a breaking change, why no changelog?

ppedrot added a commit to MetaCoq/metacoq that referenced this pull request Mar 14, 2024
ppedrot added a commit to mattam82/Coq-Equations that referenced this pull request Mar 14, 2024
proux01 added a commit to proux01/coq that referenced this pull request Mar 14, 2024
@proux01 proux01 mentioned this pull request Mar 14, 2024
@proux01
Copy link
Contributor Author

proux01 commented Mar 14, 2024

Indeed, here it is #18798

proux01 added a commit to proux01/coq that referenced this pull request Mar 18, 2024
coqbot-app bot added a commit that referenced this pull request Mar 19, 2024
Reviewed-by: SkySkimmer
Co-authored-by: SkySkimmer <SkySkimmer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Enhancement to an existing user-facing feature, tactic, etc. part: notations The notation system. part: ssreflect The SSReflect proof language.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants