New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ssr] Stop relying on camlp5 recovery mechanism #18224
Conversation
By the way, the notations |
The job library:ci-fiat_crypto_legacy has failed in allow failure mode |
Note: as future work for the notation system, we could think at how to define a notation Notation "x . N" := (hd (tl .. (tl x) ..)) (N meta-natural). or maybe Notation "x . N" := (hd (iter N tl x)) (eval iter on fixed N). |
FWIW It's probably already possible to get something like |
@coqbot run full ci |
The job library:ci-fiat_crypto_legacy has failed in allow failure mode |
🔴 CI failures at commit 49b25ce without any failure in the test-suite ✔️ Corresponding jobs for the base commit 2af3ead succeeded ❔ Ask me to try to extract minimal test cases that can be added to the test-suite 🏃
|
@coq/ssreflect-maintainers this is finally ready (windows failure in CI is unrelated) |
Let's explicitly ping @gares, I think this is an important foundational PR. |
Ping @gares for assignee again, the sooner this is merged the better I think. |
This s mostly a three lines PR, it shouldn't take much time to look at. |
@coqbot merge now |
@gares: Please take care of the following overlays:
|
This seems to be a breaking change, why no changelog? |
Indeed, here it is #18798 |
Reviewed-by: SkySkimmer Co-authored-by: SkySkimmer <SkySkimmer@users.noreply.github.com>
Stop relying on camlp5/coqpp recovery mechanism for "do [tac] => intro" and "tac; [tac|..|tac] => intro"
This is in preparation of #17876
Added / updated test-suite.Added changelog.Added / updated documentation.Documented any new / changed user messages.Updated documented syntax by runningmake doc_gram_rsts
.Opened overlay pull requests.Overlays (to be merged before the current PR)
Overlays (to be merged in sync with the current PR)