Fix check that sections are not opened when starting a module #18310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lib.sections_are_opened relies on the invariant that there are no modules in sections. This was broken by the synterp phase. We enforce the invariant in Lib with an assert and in vernac with proper user readable errors. Fix coq#18307
SkySkimmer
added
the
request: full CI
coqbot-app
bot
removed
the
request: full CI
This comment was marked as outdated.
This comment was marked as outdated.
proux01
approved these changes
Nov 21, 2023
|
@coqbot merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lib.sections_are_opened relies on the invariant that there are no modules in sections.
This was broken by the synterp phase.
We enforce the invariant in Lib with an assert and in vernac with proper user readable errors.
Fix #18307