Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control the transparency of compatibility constants via their projections. #18373

Closed
wants to merge 10 commits into from

Conversation

rlepigre
Copy link
Contributor

@rlepigre rlepigre commented Dec 6, 2023

This is roughly the first part of #18327.

  • Added changelog.
  • Added / updated documentation.
  • Updated documented syntax by running make doc_gram_rsts.
  • Opened overlay pull requests.

@rlepigre rlepigre requested review from a team as code owners December 6, 2023 14:18
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Dec 6, 2023
@herbelin
Copy link
Member

herbelin commented Dec 8, 2023

The failure of bug_17774.v is easy to fix, isn't?

@rlepigre
Copy link
Contributor Author

rlepigre commented Dec 8, 2023

The failure of bug_17774.v is easy to fix, isn't?

Probably, I did not yet had the time to look into this.

@herbelin
Copy link
Member

herbelin commented Dec 9, 2023

@coqbot run full ci

@coqbot-app coqbot-app bot removed the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Dec 9, 2023
Copy link
Contributor

coqbot-app bot commented Dec 9, 2023

🔴 CI failures at commit 8a8a22c without any failure in the test-suite

✔️ Corresponding jobs for the base commit ad8dda2 succeeded

❔ Ask me to try to extract minimal test cases that can be added to the test-suite

🏃 @coqbot ci minimize will minimize the following targets: ci-hott, ci-iris, ci-perennial, ci-unimath
  • You can also pass me a specific list of targets to minimize as arguments.
  • If you tag me saying @coqbot ci minimize all, I will additionally minimize the following targets (which I do not suggest minimizing):
    • ci-bedrock2 (because base job at ad8dda2 failed)
    • ci-jasmin (because base job at ad8dda2 failed)

@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Dec 11, 2023
@Janno
Copy link
Contributor

Janno commented Dec 11, 2023

@coqbot run full ci

@coqbot-app coqbot-app bot added needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. and removed needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. labels Dec 11, 2023
@Janno
Copy link
Contributor

Janno commented Dec 12, 2023

@coqbot run full ci

@coqbot-app coqbot-app bot added needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. and removed needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. labels Dec 12, 2023
Copy link
Contributor

coqbot-app bot commented Dec 12, 2023

🔴 CI failures at commit f62a534 without any failure in the test-suite

✔️ Corresponding jobs for the base commit c3306d6 succeeded

❔ Ask me to try to extract minimal test cases that can be added to the test-suite

🏃 @coqbot ci minimize will minimize the following targets: ci-hott, ci-iris, ci-perennial, ci-unimath
  • You can also pass me a specific list of targets to minimize as arguments.

@Janno
Copy link
Contributor

Janno commented Dec 12, 2023

@coqbot run full ci

@coqbot-app coqbot-app bot removed the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Dec 12, 2023
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Dec 12, 2023
Copy link
Contributor

coqbot-app bot commented Dec 12, 2023

🔴 CI failures at commit d1b0976 without any failure in the test-suite

✔️ Corresponding jobs for the base commit c3306d6 succeeded

❔ Ask me to try to extract minimal test cases that can be added to the test-suite

🏃 @coqbot ci minimize will minimize the following targets: ci-hott, ci-unimath
  • You can also pass me a specific list of targets to minimize as arguments.

@Janno
Copy link
Contributor

Janno commented Dec 12, 2023

@coqbot run full ci

@coqbot-app coqbot-app bot removed the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Dec 12, 2023
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Dec 14, 2023
@rlepigre
Copy link
Contributor Author

Closing since this is part of #18327.

@rlepigre rlepigre closed this Dec 14, 2023
@herbelin herbelin changed the title Control the transparency of compatibility constants via their projectons. Control the transparency of compatibility constants via their projections. Dec 24, 2023
@herbelin
Copy link
Member

herbelin commented Jan 4, 2024

Maybe this PR would still be merged quicklier if kept independent from #18327.

@rlepigre
Copy link
Contributor Author

Maybe this PR would still be merged quicklier if kept independent from #18327.

Possibly, but that would require to move the overlays here, and the other MR will hopefully be ready in the next few days (we were only stuck because the whole CI setup was broken).

@herbelin
Copy link
Member

Possibly, but that would require to move the overlays here, and the other MR will hopefully be ready in the next few days (we were only stuck because the whole CI setup was broken).

I see. Another argument I can give otherwise is that reviewing the current PR would be easier than reviewing it together with #18327 (assuming that I correctly understand that it changes the infrastructure but a priori not the observational semantics).

@rlepigre
Copy link
Contributor Author

I see. Another argument I can give otherwise is that reviewing the current PR would be easier than reviewing it together with #18327 (assuming that I correctly understand that it changes the infrastructure but a priori not the observational semantics).

I understand, but given that #18327 adds very little on top of this PR, and that it can still be easily reviewed by commit (with changes from this PR coming first), I don't think it is worth the extra effort to maintain two different PRs. But of course, if reviewing turns out to be too difficult, we can come back to taking two independent steps later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants