-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control the transparency of compatibility constants via their projections. #18373
Conversation
The failure of bug_17774.v is easy to fix, isn't? |
Probably, I did not yet had the time to look into this. |
@coqbot run full ci |
🔴 CI failures at commit 8a8a22c without any failure in the test-suite ✔️ Corresponding jobs for the base commit ad8dda2 succeeded ❔ Ask me to try to extract minimal test cases that can be added to the test-suite 🏃
|
8a8a22c
to
89df7cb
Compare
@coqbot run full ci |
@coqbot run full ci |
🔴 CI failures at commit f62a534 without any failure in the test-suite ✔️ Corresponding jobs for the base commit c3306d6 succeeded ❔ Ask me to try to extract minimal test cases that can be added to the test-suite 🏃
|
@coqbot run full ci |
🔴 CI failures at commit d1b0976 without any failure in the test-suite ✔️ Corresponding jobs for the base commit c3306d6 succeeded ❔ Ask me to try to extract minimal test cases that can be added to the test-suite 🏃
|
@coqbot run full ci |
974201f
to
dbfbe21
Compare
This is a replacement for [Tacred.evaluable_global_reference]. Co-Authored-By: Jan-Oliver Kaiser <janno@bedrocksystems.com>
We provide an override syntax, only meant for debugging, that lets one set the opacity of the compatibility constant instead of the projection (i.e., the old behaviour).
dbfbe21
to
87483bf
Compare
Closing since this is part of #18327. |
Maybe this PR would still be merged quicklier if kept independent from #18327. |
Possibly, but that would require to move the overlays here, and the other MR will hopefully be ready in the next few days (we were only stuck because the whole CI setup was broken). |
I see. Another argument I can give otherwise is that reviewing the current PR would be easier than reviewing it together with #18327 (assuming that I correctly understand that it changes the infrastructure but a priori not the observational semantics). |
I understand, but given that #18327 adds very little on top of this PR, and that it can still be easily reviewed by commit (with changes from this PR coming first), I don't think it is worth the extra effort to maintain two different PRs. But of course, if reviewing turns out to be too difficult, we can come back to taking two independent steps later. |
This is roughly the first part of #18327.
make doc_gram_rsts
.