Fixes #18342: try to insert an entry coercion when a notation in a custom entry has arguments #18447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… arguments. Then, don't create a dummy application to no arguments.
No semantic changes a priori.
herbelin
added
kind: fix
coqbot-app
bot
added
the
needs: full CI
herbelin
added
request: full CI
herbelin
added a commit
to herbelin/github-coq
that referenced
this pull request
Dec 30, 2023
coqbot-app
bot
removed
the
request: full CI
…m notations. Previously, this failed with an anomaly.
herbelin
force-pushed
the
master+fix18342-insert-entry-coercion-applied-custom-notation
branch
from
f351e77
to
8c80d32
Compare
coqbot-app
bot
added
the
needs: full CI
|
@coqbot run full ci |
coqbot-app
bot
removed
the
needs: full CI
|
@coqbot merge now |
|
@proux01: You can't merge the PR because it hasn't been approved yet. |
proux01
approved these changes
Jan 9, 2024
|
@coqbot merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an anomaly while coercion entries could have instead been inserted.
Fixes / closes #18342