Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #18434: arguments of --external in coqdoc were inadvertently swapped #18448

Merged
merged 2 commits into from Jan 9, 2024
Merged

Fixes #18434: arguments of --external in coqdoc were inadvertently swapped #18448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4adb19
Fixes #18434: arguments of --external in coqdoc were swapped.
herbelin Dec 30, 2023
efd6634
Change log for #18448
herbelin Dec 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions doc/changelog/09-cli-tools/18448-master+fix18434-coqdoc-external-regression.rst
View file
Open in desktop
@@ -0,0 +1,6 @@
- **Fixed:**
Regression in option :g:`--external` of `coqdoc`, whose two arguments
were inadvertently swapped
(`#18448 <https://github.com/coq/coq/pull/18448>`_,
fixes `#18434 <https://github.com/coq/coq/issues/18434>`_,
by Hugo Herbelin).
2 changes: 1 addition & 1 deletion tools/coqdoc/cmdArgs.ml
View file
Open in desktop
Expand Up @@ -180,7 +180,7 @@ let args_options = Arg.align [
"--verbose", arg_set (fun p -> { p with quiet = false }), " Verbose mode";
"--no-externals", arg_set (fun p -> { p with externals = false }),
" No links to Coq standard library";
"--external", arg_url_path Index.add_external_library,
"--external", arg_url_path (fun url lp -> Index.add_external_library lp url),
"<url>+<d> set URL for external library <d>";
"--coqlib_url", arg_string (fun p u -> { p with coqlib_url = u }),
"<url> Set URL for Coq standard library (default: " ^ Coq_config.wwwstdlib ^ ")";
Expand Down