Deprecate Nat and Int implementations in Numbers #18500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A library deprecation attribute has been inserted. The 3 files - theories/Numbers/Integer/Binary/ZBinary.v - theories/Numbers/Integer/NatPairs/ZNatPairs.v - theories/Numbers/Natural/Binary/NBinary.v are leaves in the stdlib and are probably not used anywhere.
coqbot-app
bot
added
the
needs: full CI
Villetaneuse
added
kind: cleanup
|
@coqbot run full ci |
coqbot-app
bot
removed
the
needs: full CI
|
@coqbot merge now |
|
@Villetaneuse sorry, I forgot something: due to the deprecation, it would be nice to add a changelog, could you add one in a separate PR? |
I'll do this asap, sorry I should have thought about it too. |
|
No hurry, there is some time left before next release ;) |
Villetaneuse
added a commit
to Villetaneuse/coq
that referenced
this pull request
Jan 19, 2024
Villetaneuse
added a commit
to Villetaneuse/coq
that referenced
this pull request
Jan 19, 2024
Villetaneuse
added a commit
to Villetaneuse/coq
that referenced
this pull request
Jan 19, 2024
Villetaneuse
added a commit
to Villetaneuse/coq
that referenced
this pull request
Jan 19, 2024
coqbot-app bot
added a commit
that referenced
this pull request
Jan 22, 2024
Reviewed-by: proux01 Co-authored-by: proux01 <proux01@users.noreply.github.com>
louiseddp
pushed a commit
to louiseddp/coq
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A library deprecation attribute has been inserted. The 3 files
theories/Numbers/Integer/Binary/ZBinary.vtheories/Numbers/Integer/NatPairs/ZNatPairs.vtheories/Numbers/Natural/Binary/NBinary.vare leaves in the stdlib and are probably not used anywhere.