Deprecate NZDomain #18539
Merged
Deprecate NZDomain #18539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coqbot-app
bot
added
the
needs: full CI
proux01
reviewed
Jan 23, 2024
theories/Numbers/NatInt/NZDomain.v
Outdated
Comment on lines
11
to
12
| Attributes deprecated(since="8.20", | ||
| note="Please open an issue if you think this file is of general interest.") |
There was a problem hiding this comment.
Suggested change
| Attributes deprecated(since="8.20", | |
| note="Please open an issue if you think this file is of general interest.") | |
| Attributes deprecated(since="8.20"). |
There was a problem hiding this comment.
Do you want the same change in the changelog?
There was a problem hiding this comment.
Why not, the sentence is not very useful.
There was a problem hiding this comment.
Done, thank you for your suggestions.
Villetaneuse
force-pushed
the
deprecate_NZDomain
branch
from
e9e7a26
to
3c7cbbd
Compare
The file NZDomain, while informative and well written, is of little use to the end user and makes NatInt depend on PeanoNat.
Villetaneuse
force-pushed
the
deprecate_NZDomain
branch
from
3c7cbbd
to
1d3fa5e
Compare
Villetaneuse
added
kind: cleanup
|
@coqbot run full ci |
coqbot-app
bot
removed
the
needs: full CI
proux01
approved these changes
Jan 24, 2024
|
@coqbot merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file NZDomain, while informative and well written, is of little use to the end user and makes NatInt depend on PeanoNat.