Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation of Qed Let in doc after #17576 #18586

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

proux01
Copy link
Contributor

@proux01 proux01 commented Jan 30, 2024

I guess it' no longer deprecated following #17576

@proux01 proux01 added the kind: documentation Additions or improvement to documentation. label Jan 30, 2024
@proux01 proux01 added this to the 8.20+rc1 milestone Jan 30, 2024
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jan 30, 2024
@proux01 proux01 marked this pull request as ready for review January 30, 2024 13:19
@proux01 proux01 requested a review from a team as a code owner January 30, 2024 13:19
@SkySkimmer SkySkimmer changed the title Remove deprecation of Qed Let after #17576 Remove deprecation of Qed Let in doc after #17576 Jan 30, 2024
@proux01
Copy link
Contributor Author

proux01 commented Feb 6, 2024

Gentle ping @coq/doc-maintainers that's a trivial one

@jfehrle jfehrle self-assigned this Feb 7, 2024
@jfehrle jfehrle removed the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Feb 7, 2024
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Feb 8, 2024
@jfehrle jfehrle removed the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Feb 9, 2024
Copy link
Member

@jfehrle jfehrle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coqbot: merge now

@coqbot-app coqbot-app bot merged commit 541eb9c into coq:master Feb 9, 2024
5 of 6 checks passed
@proux01
Copy link
Contributor Author

proux01 commented Feb 9, 2024

Thanks

@proux01 proux01 deleted the doc_let branch February 9, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: documentation Additions or improvement to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants