Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix refolding of named mutual fix/cofix defined in a section for "cbn" #18601

Merged

Conversation

herbelin
Copy link
Member

@herbelin herbelin commented Feb 1, 2024

Refolding was not yet working in cbn for global mutual fix/cofix with parameters.

The issue was mentioned e.g. in #4056 and the fix was actually much easier than imagined.

  • Added / updated test-suite.
  • Added changelog.

@herbelin herbelin added kind: fix This fixes a bug or incorrect documentation. part: tactics part: reduction strategies The Strategy command for defining reduction straegies. labels Feb 1, 2024
@herbelin herbelin added this to the 8.20+rc1 milestone Feb 1, 2024
@herbelin herbelin requested a review from a team as a code owner February 1, 2024 09:58
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Feb 1, 2024
@herbelin herbelin added the request: full CI Use this label when you want your next push to trigger a full CI. label Feb 3, 2024
@coqbot-app coqbot-app bot removed request: full CI Use this label when you want your next push to trigger a full CI. needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. labels Feb 3, 2024
@ppedrot ppedrot self-assigned this Feb 12, 2024
@ppedrot
Copy link
Member

ppedrot commented Feb 12, 2024

@coqbot merge now

@coqbot-app coqbot-app bot merged commit 71efe32 into coq:master Feb 12, 2024
5 of 6 checks passed
louiseddp pushed a commit to louiseddp/coq that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: fix This fixes a bug or incorrect documentation. part: reduction strategies The Strategy command for defining reduction straegies. part: tactics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants